From: sashiko-bot@kernel.org
To: yy-Local-LLM <yogo.0917.sabu@gmail.com>, devicetree@vger.kernel.org
Cc: linux-input@vger.kernel.org, robh@kernel.org,
conor+dt@kernel.org, dmitry.torokhov@gmail.com
Subject: Re: [PATCH RFC 5/6] mmc: sdhci: add SiRF AT550 programmed-I/O support
Date: Tue, 17 Nov 2026 13:46:32 +0000 [thread overview]
Message-ID: <sashiko-outbox-218902@kernel.org> (raw)
In-Reply-To: <20261117-at550-rfc-v1-v1-5-5879573cb825@gmail.com>
Thank you for your contribution! Sashiko AI review found 2 potential
issues to consider:
- [High] mmc: sdhci-at550: non-real identity in Signed-off-by trailer
- [Low] mmc: sdhci-at550: duplicated sdhci-pltfm helpers and premature
caps check
--
commit 9cd2cf298aedb4fdaa50a3e4221492eb7dc0dfa9
Author: yy-Local-LLM <yogo.0917.sabu@gmail.com>
> mmc: sdhci: add SiRF AT550 programmed-I/O support
>
> Add a platform SDHCI host with PIO because CPU-to-controller DMA address
> translation has not been validated. Reject unsupported
> capability/version combinations and use the current managed host
> allocation API. Board discovery and frequency restrictions are described
> by the DT, rather than forcing removable-SD policy in the controller
> driver.
>
> Signed-off-by: yy-Local-LLM <yogo.0917.sabu@gmail.com>
[Severity: High]
The Author header and Signed-off-by trailer use "yy-Local-LLM", which is a
handle or LLM identifier rather than a real person's full name as required
by the Developer's Certificate of Origin in
Documentation/process/submitting-patches.rst.
> diff --git a/drivers/mmc/host/sdhci-at550.c b/drivers/mmc/host/sdhci-at550.c
> new file mode 100644
> index 0000000000000..100a0fdb2b106
> --- /dev/null
> +++ b/drivers/mmc/host/sdhci-at550.c
> @@ -0,0 +1,62 @@
> +// SPDX-License-Identifier: GPL-2.0-only
> +/* Standard SDHCI PIO only: do not assume CPU/PCI DMA address equivalence. */
> +#include <linux/module.h>
> +#include <linux/mmc/host.h>
> +#include <linux/platform_device.h>
> +#include "sdhci-pltfm.h"
> +static const struct sdhci_ops at550_sdhci_ops = {
> + .set_clock = sdhci_set_clock,
> + .set_bus_width = sdhci_set_bus_width,
> + .reset = sdhci_reset,
> + .set_uhs_signaling = sdhci_set_uhs_signaling,
> +};
> +static const struct sdhci_pltfm_data at550_sdhci_data = {
> + .ops = &at550_sdhci_ops,
> + .quirks = SDHCI_QUIRK_BROKEN_DMA | SDHCI_QUIRK_BROKEN_ADMA,
> + .quirks2 = SDHCI_QUIRK2_NO_1_8_V,
> +};
> +static int at550_sdhci_probe(struct platform_device *pdev)
> +{
> + struct sdhci_host *host;
> + u32 caps;
> + int ret;
> +
> + host = sdhci_pltfm_init(pdev, &at550_sdhci_data, 0);
> + if (IS_ERR(host))
> + return PTR_ERR(host);
> + caps = sdhci_readl(host, SDHCI_CAPABILITIES);
> + if ((sdhci_readw(host, SDHCI_HOST_VERSION) & SDHCI_SPEC_VER_MASK) >
> + SDHCI_SPEC_200 || !(caps & SDHCI_CLOCK_BASE_MASK)) {
> + ret = -ENODEV;
> + return ret;
> + }
> + ret = mmc_of_parse(host->mmc);
> + if (ret)
> + return ret;
> + sdhci_get_property(pdev);
> + ret = sdhci_add_host(host);
> + if (!ret)
> + return 0;
> + return ret;
> +}
> +static void at550_sdhci_remove(struct platform_device *pdev)
> +{
> + sdhci_pltfm_remove(pdev);
> +}
[Severity: Low]
Does at550_sdhci_probe() need to read SDHCI_CAPABILITIES and
SDHCI_HOST_VERSION here? This runs before sdhci_add_host() ->
sdhci_setup_host() -> __sdhci_read_caps() resets the controller and applies
the sdhci-caps-mask and sdhci-caps device tree overrides, and
sdhci_setup_host() already rejects a zero base clock when
SDHCI_CLOCK_BASE_MASK is clear.
Also, at550_sdhci_ops is identical to sdhci_pltfm_ops, which
sdhci_pltfm_init() sets automatically when pdata->ops is NULL, and
sdhci_pltfm_remove can be assigned directly to at550_sdhci_driver.remove
without the at550_sdhci_remove() wrapper.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261117-at550-rfc-v1-v1-0-5879573cb825@gmail.com?part=5
next prev parent reply other threads:[~2026-11-17 13:46 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-17 13:06 [PATCH RFC 0/6] SiRF AT550 / YPL514si initial RAM-boot platform support yy-Local-LLM via B4 Relay
2026-11-17 13:06 ` yy-Local-LLM
2026-11-17 13:06 ` [PATCH RFC 1/6] dt-bindings: add SiRF AT550 and Yupiteru YPL514si descriptions yy-Local-LLM via B4 Relay
2026-11-17 13:06 ` yy-Local-LLM
2026-11-17 13:21 ` sashiko-bot
2026-11-17 17:28 ` Conor Dooley
2026-11-17 13:06 ` [PATCH RFC 2/6] irqchip: add the SiRF AT550 interrupt controller yy-Local-LLM via B4 Relay
2026-11-17 13:06 ` yy-Local-LLM
2026-11-17 13:27 ` sashiko-bot
2026-11-17 13:06 ` [PATCH RFC 3/6] clocksource: add the SiRF AT550 counter and match timer yy-Local-LLM via B4 Relay
2026-11-17 13:06 ` yy-Local-LLM
2026-11-17 13:43 ` sashiko-bot
2026-11-17 13:06 ` [PATCH RFC 4/6] Input: add polled SiRF AT550 resistive touch support yy-Local-LLM via B4 Relay
2026-11-17 13:06 ` yy-Local-LLM
2026-11-17 13:38 ` sashiko-bot
2026-11-17 13:06 ` [PATCH RFC 5/6] mmc: sdhci: add SiRF AT550 programmed-I/O support yy-Local-LLM via B4 Relay
2026-11-17 13:06 ` yy-Local-LLM
2026-11-17 13:46 ` sashiko-bot [this message]
2026-11-17 13:06 ` [PATCH RFC 6/6] ARM: add the SiRF AT550 platform and YPL514si board yy-Local-LLM via B4 Relay
2026-11-17 13:06 ` yy-Local-LLM
2026-11-17 13:17 ` Arnd Bergmann
2026-11-17 17:23 ` Conor Dooley
2026-11-17 14:05 ` sashiko-bot
2026-11-18 8:14 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-218902@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=yogo.0917.sabu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.