From: sashiko-bot@kernel.org
To: yy-Local-LLM <yogo.0917.sabu@gmail.com>, devicetree@vger.kernel.org
Cc: linux-input@vger.kernel.org, robh@kernel.org,
conor+dt@kernel.org, dmitry.torokhov@gmail.com
Subject: Re: [PATCH RFC 6/6] ARM: add the SiRF AT550 platform and YPL514si board
Date: Tue, 17 Nov 2026 14:05:06 +0000 [thread overview]
Message-ID: <sashiko-outbox-218920@kernel.org> (raw)
In-Reply-To: <20261117-at550-rfc-v1-v1-6-5879573cb825@gmail.com>
Thank you for your contribution! Sashiko AI review found 5 potential
issues to consider:
- [High] ARM: at550: non-real name yy-Local-LLM in Signed-off-by and
MAINTAINERS
- [High] ARM: at550: ARCH_AT550 selects CPU_V6 without !SMP dependency
in Kconfig
- [High] ARM: dts: at550: /memreserve/ causes ioremap_wc() failure in
simplefb_probe()
- [Low] ARM: at550_defconfig: missing CONFIG_ARCH_MULTI_V7 disablement
- [Low] ARM: dts: unsorted subdir-y entry and missing newline in
Makefile
--
commit 77bddca305316e26eed799b27f4f024275217704
Author: yy-Local-LLM <yogo.0917.sabu@gmail.com>
> ARM: add the SiRF AT550 platform and YPL514si board
>
> Add a minimal DT machine using standard IRQ, timer and simplefb paths.
> Describe the SoC and the firmware-configured YPL514si display. Leave
> usable memory and the divided counter rate for the bootloader to
> populate. Keep optional peripheral nodes disabled until firmware hands
> them over. Disable unvalidated board suspend; limit this board to SD PIO
> at 25 MHz. Document the RAM-boot contract and the missing
> cold-boot/clock-tree support.
>
> Signed-off-by: yy-Local-LLM <yogo.0917.sabu@gmail.com>
[Severity: High]
Documentation/process/submitting-patches.rst requires a real full human
name in the Signed-off-by trailer and in MAINTAINERS rather than a handle
or bot name (yy-Local-LLM).
[ ... ]
> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> index 28fba538d5520..a4844a80b8d08 100644
> --- a/arch/arm/boot/dts/Makefile
> +++ b/arch/arm/boot/dts/Makefile
> @@ -40,3 +40,5 @@ subdir-y += vt8500
> subdir-y += xen
> subdir-y += xilinx
> subdir-y += zte
> +
> +subdir-y += sirf
> \ No newline at end of file
[Severity: Low]
This isn't a bug, but the vendor subdirectories in this Makefile are kept
in alphabetical order (between sigmastar and socionext), without a blank
line, and the file is missing a trailing newline.
[ ... ]
> diff --git a/arch/arm/boot/dts/sirf/at550-ypl514si.dts b/arch/arm/boot/dts/sirf/at550-ypl514si.dts
> new file mode 100644
> index 0000000000000..d45328fa09e82
> --- /dev/null
> +++ b/arch/arm/boot/dts/sirf/at550-ypl514si.dts
> @@ -0,0 +1,52 @@
> +// SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +/dts-v1/;
> +/memreserve/ 0xc0100000 0x40000;
> +#include "at550.dtsi"
> +
> +/ {
> + model = "Yupiteru YPL514si";
> + compatible = "yupiteru,ypl514si", "sirf,at550";
> +
> + memory@c0000000 {
> + device_type = "memory";
> + /* The bootloader supplies the region allocated for Linux. */
> + reg = <0xc0000000 0>;
> + };
> +
> + chosen {
> + #address-cells = <1>;
> + #size-cells = <1>;
> + ranges;
> +
> + framebuffer@c0100000 {
> + compatible = "simple-framebuffer";
> + reg = <0xc0100000 0x3fc00>;
> + width = <480>;
> + height = <272>;
> + stride = <960>;
> + format = "r5g6b5";
> + status = "disabled";
> + };
> + };
> +};
[Severity: High]
Will reserving the framebuffer with /memreserve/ cause simplefb_probe() to
fail on 32-bit arm?
/memreserve/ only calls memblock_reserve() without setting MEMBLOCK_NOMAP,
so map_lowmem() still maps 0xc0100000 into the kernel linear mapping when
memory@c0000000 covers that range. When simplefb_probe() then calls
ioremap_wc(), __arm_ioremap_pfn_caller() hits a WARN_ON() and returns NULL
to reject the mismatched memory attribute alias, failing probe with
-ENOMEM:
arch/arm/mm/ioremap.c:__arm_ioremap_pfn_caller() {
...
if (WARN_ON(memblock_is_map_memory(PFN_PHYS(pfn)) &&
mtype != MT_MEMORY_RW))
return NULL;
...
}
Reserving the region via a /reserved-memory child node with the no-map
property excludes it from the linear mapping so ioremap_wc() succeeds.
[ ... ]
> diff --git a/arch/arm/configs/at550_defconfig b/arch/arm/configs/at550_defconfig
> new file mode 100644
> index 0000000000000..698b2f67574d0
> --- /dev/null
> +++ b/arch/arm/configs/at550_defconfig
> @@ -0,0 +1,34 @@
> +# CONFIG_LOCALVERSION_AUTO is not set
> +CONFIG_SYSVIPC=y
> +CONFIG_NO_HZ_IDLE=y
> +CONFIG_HIGH_RES_TIMERS=y
> +CONFIG_BLK_DEV_INITRD=y
> +CONFIG_ARCH_MULTI_V6=y
> +CONFIG_ARCH_AT550=y
[Severity: Low]
Should at550_defconfig explicitly disable CONFIG_ARCH_MULTI_V7?
ARCH_MULTI_V7 defaults to y in arch/arm/Kconfig.platforms, so omitting
"# CONFIG_ARCH_MULTI_V7 is not set" leaves CPU_V7, HAVE_SMP, multi-CPU/TLB
dispatch, and a 64-byte L1 cache line shift enabled for this single-core
ARM1136 target.
[ ... ]
> diff --git a/arch/arm/mach-at550/Kconfig b/arch/arm/mach-at550/Kconfig
> new file mode 100644
> index 0000000000000..c6380e529641d
> --- /dev/null
> +++ b/arch/arm/mach-at550/Kconfig
> @@ -0,0 +1,13 @@
> +# SPDX-License-Identifier: GPL-2.0-only
> +config ARCH_AT550
> + bool "SiRF AT550 platforms"
> + depends on ARCH_MULTI_V6
> + select ARM_ERRATA_411920
> + select AT550_IRQ
> + select CLKSRC_AT550
> + select CPU_V6
[Severity: High]
Does selecting CPU_V6 without a !SMP dependency break multiplatform SMP
builds?
In arch/arm/mm/Kconfig, CPU_V6 depends on !SMP. Enabling CONFIG_ARCH_AT550
in a configuration with CONFIG_SMP=y (such as allmodconfig or a combined
v6/v7 multiplatform kernel) triggers an unmet direct dependency warning for
CPU_V6 and compiles out 1-byte and 2-byte __arch_xchg() and 2-byte
__cmpxchg() in arch/arm/include/asm/cmpxchg.h, causing link failures with
undefined references to __bad_xchg and __bad_cmpxchg (and smp_on_up when
CONFIG_SMP_ON_UP=n).
Other ARM1136 platforms either select CPU_ARM1136R1 (which selects CPU_V6K)
or depend on !SMP when selecting CPU_ARM1136R0 / CPU_V6.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261117-at550-rfc-v1-v1-0-5879573cb825@gmail.com?part=6
next prev parent reply other threads:[~2026-11-17 14:05 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-17 13:06 [PATCH RFC 0/6] SiRF AT550 / YPL514si initial RAM-boot platform support yy-Local-LLM via B4 Relay
2026-11-17 13:06 ` yy-Local-LLM
2026-11-17 13:06 ` [PATCH RFC 1/6] dt-bindings: add SiRF AT550 and Yupiteru YPL514si descriptions yy-Local-LLM via B4 Relay
2026-11-17 13:06 ` yy-Local-LLM
2026-11-17 13:21 ` sashiko-bot
2026-11-17 17:28 ` Conor Dooley
2026-11-17 13:06 ` [PATCH RFC 2/6] irqchip: add the SiRF AT550 interrupt controller yy-Local-LLM via B4 Relay
2026-11-17 13:06 ` yy-Local-LLM
2026-11-17 13:27 ` sashiko-bot
2026-11-17 13:06 ` [PATCH RFC 3/6] clocksource: add the SiRF AT550 counter and match timer yy-Local-LLM via B4 Relay
2026-11-17 13:06 ` yy-Local-LLM
2026-11-17 13:43 ` sashiko-bot
2026-11-17 13:06 ` [PATCH RFC 4/6] Input: add polled SiRF AT550 resistive touch support yy-Local-LLM via B4 Relay
2026-11-17 13:06 ` yy-Local-LLM
2026-11-17 13:38 ` sashiko-bot
2026-11-17 13:06 ` [PATCH RFC 5/6] mmc: sdhci: add SiRF AT550 programmed-I/O support yy-Local-LLM via B4 Relay
2026-11-17 13:06 ` yy-Local-LLM
2026-11-17 13:46 ` sashiko-bot
2026-11-17 13:06 ` [PATCH RFC 6/6] ARM: add the SiRF AT550 platform and YPL514si board yy-Local-LLM via B4 Relay
2026-11-17 13:06 ` yy-Local-LLM
2026-11-17 13:17 ` Arnd Bergmann
2026-11-17 17:23 ` Conor Dooley
2026-11-17 14:05 ` sashiko-bot [this message]
2026-11-18 8:14 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-218920@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=yogo.0917.sabu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.