From: sashiko-bot@kernel.org
To: "lei lei" <llleigoing@outlook.com>
Cc: "mptcp@lists.linux.dev" <mptcp@lists.linux.dev>
Subject: Re: [PATCH net 2/3] net: bound receive window predictions before narrowing
Date: Wed, 18 Nov 2026 05:22:20 +0000 [thread overview]
Message-ID: <sashiko-outbox-220155@kernel.org> (raw)
In-Reply-To: <20261117052200.1507847-3-llleigoing@outlook.com>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [High] net: invalid handle and author mismatch in Signed-off-by
trailer
--
commit 0e17123a2c1e28d81f7aa6b0170c8d97f7b356e5
Author: lei lei <llleigoing@outlook.com>
> net: bound receive window predictions before narrowing
>
> tcp_rcvbuf_grow() and mptcp_rcvbuf_grow() compute growth terms in u64 but
> accumulate the predicted receive window in u32. The prediction can wrap
> before conversion to a memory budget and application of tcp_rmem[2].
>
> For example, oldval=16 KiB and newval=4104 KiB produce a slow-start
> window prediction of 4 GiB + 8 MiB. Storing it in u32 leaves only 8 MiB,
> so the memory limit is applied to an already truncated prediction.
>
> Keep rcvwin in u64 and promote newval before the initial shift. Clamp
> the completed prediction at INT_MAX before passing it to the existing
> int-input window-to-memory helpers. Since scaling_ratio is a nonzero
> u8, the required memory is at least as large as the window. Predictions
> above INT_MAX therefore already require a saturated receive budget.
> The helpers' return saturation and the existing tcp_rmem[2] limit then
> provide the appropriate memory bound.
>
> TCP and MPTCP loopback tests using small warm-up reads followed by a
> queued burst of about 4 MiB previously left the budget below the
> configured 64 MiB limit. With this change, both reach that limit.
>
> Fixes: aa251c84636c ("tcp: fix too slow tcp_rcvbuf_grow() action")
> Signed-off-by: lllei <llleigoing@outlook.com>
[Severity: High]
The Signed-off-by trailer uses the single-word handle "lllei" instead of a
real human name and does not match the commit Author header ("lei lei").
Documentation/process/submitting-patches.rst requires a full real name in
Signed-off-by that matches the commit author.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261117052200.1507847-1-llleigoing@outlook.com?part=2
next prev parent reply other threads:[~2026-11-18 5:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-17 5:22 [PATCH net 0/3] tcp, mptcp: fix receive buffer sizing and peek accounting lei lei
2026-11-17 5:22 ` [PATCH net 1/3] tcp: saturate window-to-memory conversions at INT_MAX lei lei
2026-11-18 5:22 ` sashiko-bot
2026-11-17 5:22 ` [PATCH net 2/3] net: bound receive window predictions before narrowing lei lei
2026-11-18 5:22 ` sashiko-bot [this message]
2026-11-17 5:22 ` [PATCH net 3/3] mptcp: exclude MSG_PEEK from receive buffer autotuning lei lei
2026-11-18 5:22 ` sashiko-bot
2026-11-17 7:04 ` [PATCH net 0/3] tcp, mptcp: fix receive buffer sizing and peek accounting MPTCP CI
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-220155@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=llleigoing@outlook.com \
--cc=mptcp@lists.linux.dev \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.