All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "lei lei" <llleigoing@outlook.com>
Cc: "mptcp@lists.linux.dev" <mptcp@lists.linux.dev>
Subject: Re: [PATCH net 1/3] tcp: saturate window-to-memory conversions at INT_MAX
Date: Wed, 18 Nov 2026 05:22:19 +0000	[thread overview]
Message-ID: <sashiko-outbox-220154@kernel.org> (raw)
In-Reply-To: <20261117052200.1507847-2-llleigoing@outlook.com>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [High] tcp: invalid Signed-off-by trailer using handle instead of real
  name
--

commit 7ae76d33251cff52d3abaf1bc0db22dbfc70f04d
Author: lei lei <llleigoing@outlook.com>

> tcp: saturate window-to-memory conversions at INT_MAX
>
> __tcp_space_from_win() computes a receive-memory requirement in u64 but
> returns int. A result above INT_MAX can therefore become negative or
> wrap to a smaller positive value before the caller compares or limits it.
>
> TCP and MPTCP SO_RCVLOWAT handling compare this result with sk_rcvbuf.
> They can accept a large low watermark without increasing the receive
> budget because the truncated requirement appears smaller than the
> existing buffer. Receive autotuning uses the same conversion helper.
>
> Saturate the u64 result at INT_MAX before returning it. This matches the
> int type of sk_rcvbuf and preserves the value and rounding of every
> representable result.
>
> TCP and MPTCP loopback tests with tcp_rmem[2]=INT_MAX and
> SO_RCVLOWAT=INT_MAX/2 reproduce the missed update after learning a
> scaling ratio below 128. With this change, both budgets reach INT_MAX.
>
> Fixes: dfa2f0483360 ("tcp: get rid of sysctl_tcp_adv_win_scale")
> Signed-off-by: lllei <llleigoing@outlook.com>

[Severity: High]
The Signed-off-by trailer uses the single-word handle "lllei" instead of a
real human name matching the Author header, which violates Developer's
Certificate of Origin requirements in
Documentation/process/submitting-patches.rst.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261117052200.1507847-1-llleigoing@outlook.com?part=1

  reply	other threads:[~2026-11-18  5:22 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-17  5:22 [PATCH net 0/3] tcp, mptcp: fix receive buffer sizing and peek accounting lei lei
2026-11-17  5:22 ` [PATCH net 1/3] tcp: saturate window-to-memory conversions at INT_MAX lei lei
2026-11-18  5:22   ` sashiko-bot [this message]
2026-11-17  5:22 ` [PATCH net 2/3] net: bound receive window predictions before narrowing lei lei
2026-11-18  5:22   ` sashiko-bot
2026-11-17  5:22 ` [PATCH net 3/3] mptcp: exclude MSG_PEEK from receive buffer autotuning lei lei
2026-11-18  5:22   ` sashiko-bot
2026-11-17  7:04 ` [PATCH net 0/3] tcp, mptcp: fix receive buffer sizing and peek accounting MPTCP CI

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-220154@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=llleigoing@outlook.com \
    --cc=mptcp@lists.linux.dev \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.