All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH net 0/3] tcp, mptcp: fix receive buffer sizing and peek accounting
@ 2026-11-17  5:22 lei lei
  2026-11-17  5:22 ` [PATCH net 1/3] tcp: saturate window-to-memory conversions at INT_MAX lei lei
                   ` (3 more replies)
  0 siblings, 4 replies; 8+ messages in thread
From: lei lei @ 2026-11-17  5:22 UTC (permalink / raw)
  To: netdev@vger.kernel.org
  Cc: mptcp@lists.linux.dev, edumazet@kernel.org, ncardwell@google.com,
	kuniyu@google.com, davem@davemloft.net, kuba@kernel.org,
	pabeni@redhat.com, horms@kernel.org, matttbe@kernel.org,
	martineau@kernel.org, geliang@kernel.org

This series fixes receive-buffer sizing and accounting errors in TCP
and MPTCP.

The first two patches prevent integer truncation from producing an
undersized receive-memory budget. __tcp_space_from_win() can return a
truncated int, while tcp_rcvbuf_grow() and mptcp_rcvbuf_grow() can wrap
a u32 window prediction. The fixes saturate the conversion result at
INT_MAX and keep growth predictions in u64 until they are bounded for
the existing helper interface. Patch 2 depends on patch 1.

The third patch restores the MSG_PEEK exclusion from MPTCP receive
autotuning. Repeated peeks currently count the same queued bytes as
application consumption, which can inflate the receive-memory budget
without the application draining the queue.

Validation used targeted IPv4 loopback socket tests on unpatched and
patched kernels in x86_64 QEMU/KVM guests. GCC 13.3 builds completed
without warnings. The tests confirmed that, with the fixes applied:

  - Large SO_RCVLOWAT settings on TCP and MPTCP correctly increase the
    receive-memory budget to INT_MAX when tcp_rmem[2] is INT_MAX and
    the window-to-memory conversion exceeds the representable range.
  - For queued bursts whose predicted window exceeds 32 bits, TCP and
    MPTCP receive budgets now reach the configured 64 MiB limit.
  - Repeated MSG_PEEK calls leave both a fixed 32 KiB MPTCP receive
    queue and its memory budget unchanged. A subsequent consuming read
    returns the original data intact.

The investigation began with sk_rcvbuf failing to grow despite
application reads during normal use, constraining the advertised
receive window.

OpenAI Codex assisted with designing trigger conditions and socket
tests for reproduction and validation.

lllei (3):
  tcp: saturate window-to-memory conversions at INT_MAX
  net: bound receive window predictions before narrowing
  mptcp: exclude MSG_PEEK from receive buffer autotuning

 include/net/tcp.h    |  2 +-
 net/ipv4/tcp_input.c | 11 ++++++-----
 net/mptcp/protocol.c | 12 +++++++-----
 3 files changed, 14 insertions(+), 11 deletions(-)


base-commit: aa40afa831ebfe45e40a23721711059f2ac584d4
-- 
2.43.0


^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2026-11-18  5:22 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-17  5:22 [PATCH net 0/3] tcp, mptcp: fix receive buffer sizing and peek accounting lei lei
2026-11-17  5:22 ` [PATCH net 1/3] tcp: saturate window-to-memory conversions at INT_MAX lei lei
2026-11-18  5:22   ` sashiko-bot
2026-11-17  5:22 ` [PATCH net 2/3] net: bound receive window predictions before narrowing lei lei
2026-11-18  5:22   ` sashiko-bot
2026-11-17  5:22 ` [PATCH net 3/3] mptcp: exclude MSG_PEEK from receive buffer autotuning lei lei
2026-11-18  5:22   ` sashiko-bot
2026-11-17  7:04 ` [PATCH net 0/3] tcp, mptcp: fix receive buffer sizing and peek accounting MPTCP CI

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.