All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "lei lei" <llleigoing@outlook.com>
Cc: "mptcp@lists.linux.dev" <mptcp@lists.linux.dev>
Subject: Re: [PATCH net 3/3] mptcp: exclude MSG_PEEK from receive buffer autotuning
Date: Wed, 18 Nov 2026 05:22:20 +0000	[thread overview]
Message-ID: <sashiko-outbox-220156@kernel.org> (raw)
In-Reply-To: <20261117052200.1507847-4-llleigoing@outlook.com>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [High] mptcp: invalid Signed-off-by trailer using handle instead of
  real name
--

commit bf35feefb3ca938f4410fd363b5311a7fad1ae8f
Author: lei lei <llleigoing@outlook.com>

> mptcp: exclude MSG_PEEK from receive buffer autotuning
>
> __mptcp_recvmsg_mskq() passes bytes copied by MSG_PEEK to
> mptcp_rcv_space_adjust(), although those bytes remain in the receive
> queue. Repeated peeks count the same data as new application
> consumption and can inflate the receive-memory budget. Subtracting the
> unread queue at a measurement boundary cannot undo that repeated count.
>
> The receive path originally skipped this adjustment for MSG_PEEK.
> Commit 581302298524 ("mptcp: error out earlier on disconnect") moved
> the adjustment calls without preserving that check.
>
> Only adjust receive space for non-peeking reads. Keep the returned
> byte count unchanged.
>
> A loopback test leaves a fixed 32 KiB queue unread and peeks 4096 times.
> Before this change, sk_rcvbuf grows to the configured 8 MiB limit.
> Afterwards, both the budget and the queue remain unchanged, and a
> subsequent consuming read returns the original data intact.
>
> Fixes: 581302298524 ("mptcp: error out earlier on disconnect")
> Signed-off-by: lllei <llleigoing@outlook.com>

[Severity: High]
The Signed-off-by trailer uses the single-word handle "lllei" instead of
a real full human name and does not match the commit Author header ("lei
lei"), which violates the Developer's Certificate of Origin requirements
in Documentation/process/submitting-patches.rst.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261117052200.1507847-1-llleigoing@outlook.com?part=3

  reply	other threads:[~2026-11-18  5:22 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-17  5:22 [PATCH net 0/3] tcp, mptcp: fix receive buffer sizing and peek accounting lei lei
2026-11-17  5:22 ` [PATCH net 1/3] tcp: saturate window-to-memory conversions at INT_MAX lei lei
2026-11-18  5:22   ` sashiko-bot
2026-11-17  5:22 ` [PATCH net 2/3] net: bound receive window predictions before narrowing lei lei
2026-11-18  5:22   ` sashiko-bot
2026-11-17  5:22 ` [PATCH net 3/3] mptcp: exclude MSG_PEEK from receive buffer autotuning lei lei
2026-11-18  5:22   ` sashiko-bot [this message]
2026-11-17  7:04 ` [PATCH net 0/3] tcp, mptcp: fix receive buffer sizing and peek accounting MPTCP CI

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-220156@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=llleigoing@outlook.com \
    --cc=mptcp@lists.linux.dev \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.