From: Trond Myklebust <trond.myklebust@fys.uio.no>
To: Andrew Morton <akpm@digeo.com>
Cc: Felipe Alfaro Solana <felipe_alfaro@linuxmail.org>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Trond Myklebust <trond.myklebust@fys.uio.no>,
Neil Brown <neilb@cse.unsw.edu.au>
Subject: Re: 2.5.69-mm9
Date: 26 May 2003 01:19:54 +0200 [thread overview]
Message-ID: <shsk7ceaa1x.fsf@charged.uio.no> (raw)
In-Reply-To: <20030525154840.3ba7609b.akpm@digeo.com>
>>>>> " " == Andrew Morton <akpm@digeo.com> writes:
> I would be inclined to say that this is a hitherto undiscovered
> use-after-free bug.
Does the following fix it?
Cheers,
Trond
--- linux-2.5.69/net/sunrpc/svcsock.c.orig 2003-05-20 08:34:35.000000000 +0200
+++ linux-2.5.69/net/sunrpc/svcsock.c 2003-05-26 01:16:33.000000000 +0200
@@ -600,6 +600,7 @@
return 0;
}
local_bh_enable();
+ svsk->sk_sk->stamp = skb->stamp;
skb_free_datagram(svsk->sk_sk, skb);
} else {
/* we can use it in-place */
@@ -614,6 +615,7 @@
skb->ip_summed = CHECKSUM_UNNECESSARY;
}
rqstp->rq_skbuff = skb;
+ svsk->sk_sk->stamp = skb->stamp;
}
rqstp->rq_arg.page_base = 0;
@@ -629,7 +631,6 @@
serv->sv_stats->netudpcnt++;
/* One down, maybe more to go... */
- svsk->sk_sk->stamp = skb->stamp;
svc_sock_received(svsk);
return len;
WARNING: multiple messages have this Message-ID (diff)
From: Trond Myklebust <trond.myklebust@fys.uio.no>
To: Andrew Morton <akpm@digeo.com>
Cc: Felipe Alfaro Solana <felipe_alfaro@linuxmail.org>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Trond Myklebust <trond.myklebust@fys.uio.no>,
Neil Brown <neilb@cse.unsw.edu.au>
Subject: Re: 2.5.69-mm9
Date: 26 May 2003 01:19:54 +0200 [thread overview]
Message-ID: <shsk7ceaa1x.fsf@charged.uio.no> (raw)
In-Reply-To: <20030525154840.3ba7609b.akpm@digeo.com>
>>>>> " " == Andrew Morton <akpm@digeo.com> writes:
> I would be inclined to say that this is a hitherto undiscovered
> use-after-free bug.
Does the following fix it?
Cheers,
Trond
--- linux-2.5.69/net/sunrpc/svcsock.c.orig 2003-05-20 08:34:35.000000000 +0200
+++ linux-2.5.69/net/sunrpc/svcsock.c 2003-05-26 01:16:33.000000000 +0200
@@ -600,6 +600,7 @@
return 0;
}
local_bh_enable();
+ svsk->sk_sk->stamp = skb->stamp;
skb_free_datagram(svsk->sk_sk, skb);
} else {
/* we can use it in-place */
@@ -614,6 +615,7 @@
skb->ip_summed = CHECKSUM_UNNECESSARY;
}
rqstp->rq_skbuff = skb;
+ svsk->sk_sk->stamp = skb->stamp;
}
rqstp->rq_arg.page_base = 0;
@@ -629,7 +631,6 @@
serv->sv_stats->netudpcnt++;
/* One down, maybe more to go... */
- svsk->sk_sk->stamp = skb->stamp;
svc_sock_received(svsk);
return len;
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org"> aart@kvack.org </a>
next prev parent reply other threads:[~2003-05-25 23:07 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-05-25 11:27 2.5.69-mm9 Andrew Morton
2003-05-25 11:27 ` 2.5.69-mm9 Andrew Morton
2003-05-25 12:50 ` 2.5.69-mm9 Daniele Bellucci
2003-05-25 12:56 ` 2.5.69-mm9 Rudmer van Dijk
2003-05-25 12:56 ` 2.5.69-mm9 Rudmer van Dijk
2003-05-25 13:58 ` 2.5.69-mm9 Ed Sweetman
2003-05-25 14:07 ` 2.5.69-mm9 Ed Sweetman
2003-05-25 20:06 ` 2.5.69-mm9 Andrew Morton
2003-05-25 20:06 ` 2.5.69-mm9 Andrew Morton
2003-05-25 20:29 ` 2.5.69-mm9 Adrian Bunk
2003-05-25 20:29 ` 2.5.69-mm9 Adrian Bunk
2003-05-25 16:47 ` 2.5.69-mm9 Nicholas Wourms
2003-05-25 16:47 ` 2.5.69-mm9 Nicholas Wourms
2003-05-25 17:06 ` 2.5.69-mm9 Adam Kropelin
2003-05-25 17:06 ` 2.5.69-mm9 Adam Kropelin
2003-05-25 20:54 ` 2.5.69-mm9: undefined references to `router_devlist' Adrian Bunk
2003-05-26 13:15 ` Arnaldo Carvalho de Melo
2003-05-27 2:34 ` [PATCH] wanrouter: fix bug introduced by latest namespace fix Arnaldo Carvalho de Melo
2003-05-27 7:08 ` David S. Miller
2003-05-25 21:56 ` 2.5.69-mm9 Felipe Alfaro Solana
2003-05-25 22:48 ` 2.5.69-mm9 Andrew Morton
2003-05-25 22:48 ` 2.5.69-mm9 Andrew Morton
2003-05-25 23:16 ` 2.5.69-mm9 Neil Brown
2003-05-25 23:16 ` 2.5.69-mm9 Neil Brown
2003-05-25 23:19 ` Trond Myklebust [this message]
2003-05-25 23:19 ` 2.5.69-mm9 Trond Myklebust
2003-05-26 18:30 ` 2.5.69-mm9 Daniele Bellucci
2003-05-26 19:20 ` 2.5.69-mm9 Daniele Bellucci
-- strict thread matches above, loose matches on Subject: below --
2003-05-25 15:19 2.5.69-mm9 Alistair J Strachan
2003-05-25 20:15 ` 2.5.69-mm9 Andrew Morton
2003-05-25 20:35 ` 2.5.69-mm9 Alistair J Strachan
2003-05-25 20:51 ` 2.5.69-mm9 Mike Fedyk
2003-05-25 20:55 ` 2.5.69-mm9 Andrew Morton
[not found] <20030525172746.43b9866d.akpm@digeo.com>
[not found] ` <20030529204324.GF25560@kroah.com>
2003-05-29 23:48 ` 2.5.69-mm9 Alistair J Strachan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=shsk7ceaa1x.fsf@charged.uio.no \
--to=trond.myklebust@fys.uio.no \
--cc=akpm@digeo.com \
--cc=felipe_alfaro@linuxmail.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=neilb@cse.unsw.edu.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.