NFS/TCP patches against 2.4.18 have problems

NFS/TCP patches against 2.4.18 have problems

[Bryan O'Sullivan]

Hi, Trond -

I've been taking a look at the following patches from your web site:

  linux-2.4.18-svc_tcp.dif.bz2
  linux-2.4.18-rpc_tweaks.dif.bz2

In the accompanying commentary, you mention that the rpc_tweaks patch
applies on top of the svc_tcp patch, but this is not the case.  I get
two very substantial rejects, in net/sunrpc/xprt.c and
include/linux/sunrpc/xprt.h.

It looks like the rpc_tweaks patch includes some fixes that were
developed in parallel, but in a different way, during 2.4.18
development.  Before I leap into figuring out how to munge the patch so
that it applies, I wanted to check if you've taken a look at the rejects
yourself.

Thanks,

	<b


-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
No, I will not fix your computer.
http://thinkgeek.com/sf
_______________________________________________
NFS maillist  -  NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs

Re: NFS/TCP patches against 2.4.18 have problems

[Trond Myklebust]

>>>>> " " == Bryan O'Sullivan <bos@serpentine.com> writes:

     > Hi, Trond - I've been taking a look at the following patches
     > from your web site:

     >   linux-2.4.18-svc_tcp.dif.bz2 linux-2.4.18-rpc_tweaks.dif.bz2

     > In the accompanying commentary, you mention that the rpc_tweaks
     > patch applies on top of the svc_tcp patch, but this is not the
     > case.  I get two very substantial rejects, in net/sunrpc/xprt.c
     > and include/linux/sunrpc/xprt.h.

Yes. The rpc_tweaks patch also relies on some other changes. Most
notably, it assumes that the 'ping' patch (and possibly 'rpc_bkl')
have been applied...

Cheers,
  Trond


-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
Bringing you mounds of caffeinated joy.
http://thinkgeek.com/sf
_______________________________________________
NFS maillist  -  NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs

Re: NFS/TCP patches against 2.4.18 have problems

[Bryan O'Sullivan]

On Fri, 2002-07-05 at 05:41, Trond Myklebust wrote:

> Yes. The rpc_tweaks patch also relies on some other changes. Most
> notably, it assumes that the 'ping' patch (and possibly 'rpc_bkl')
> have been applied...

Thanks, that made a difference.  Might be worth stating explicitly on
the web page, though :-)

By the way, the fattr patch that the BKL removal patch depends on does
not appear to exist.

	<b


-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
Bringing you mounds of caffeinated joy.
http://thinkgeek.com/sf
_______________________________________________
NFS maillist  -  NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs