Re: [PATCH v3 3/9] hw/audio/virtio-sound: free all stream buffers on reset

[Manos Pitsidianakis <manos.pitsidianakis@linaro.org>]

On Fri, 26 Jun 2026 15:35, Alexander Mikhalitsyn <alexander@mihalicyn.com> wrote:
>From: Volker Rümelin <vr_qemu@t-online.de>
>
>All remaining stream buffers in the stream queues must
>be freed after a reset. This is the initial state of the
>virtio-sound device.
>
>Signed-off-by: Volker Rümelin <vr_qemu@t-online.de>
>[AM: trivial variable rename s -> vsnd]
>Signed-off-by: Alexander Mikhalitsyn <aleksandr.mikhalitsyn@futurfusion.io>
>Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
>---
> hw/audio/virtio-snd.c | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
>diff --git a/hw/audio/virtio-snd.c b/hw/audio/virtio-snd.c
>index 859c2770195..8f4421ba844 100644
>--- a/hw/audio/virtio-snd.c
>+++ b/hw/audio/virtio-snd.c
>@@ -1340,6 +1340,7 @@ static void virtio_snd_reset(VirtIODevice *vdev)
> {
>     VirtIOSound *vsnd = VIRTIO_SND(vdev);
>     virtio_snd_ctrl_command *cmd;
>+    uint32_t i;
> 
>     /*
>      * Sanity check that the invalid buffer message queue is emptied at the end
>@@ -1353,6 +1354,16 @@ static void virtio_snd_reset(VirtIODevice *vdev)
>         QTAILQ_REMOVE(&vsnd->cmdq, cmd, next);
>         virtio_snd_ctrl_cmd_free(cmd);
>     }
>+
>+    for (i = 0; i < vsnd->snd_conf.streams; i++) {

Or:

+    for (uint32_t i = 0; i < vsnd->snd_conf.streams; i++) {

Either way,

Reviewed-by: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>

>+        VirtIOSoundPCMStream *stream = &vsnd->streams[i];
>+        VirtIOSoundPCMBuffer *buffer;
>+
>+        while ((buffer = QSIMPLEQ_FIRST(&stream->queue))) {
>+            QSIMPLEQ_REMOVE_HEAD(&stream->queue, entry);
>+            virtio_snd_pcm_buffer_free(buffer);
>+        }
>+    }
> }
> 
> static void virtio_snd_class_init(ObjectClass *klass, const void *data)
>-- 
>2.47.3
>