Re: [PATCH v3 6/9] hw/audio/virtio-sound: introduce virtio_snd_pcm_open()

[Manos Pitsidianakis <manos.pitsidianakis@linaro.org>]

On Fri, 26 Jun 2026 15:35, Alexander Mikhalitsyn <alexander@mihalicyn.com> wrote:
>From: Volker Rümelin <vr_qemu@t-online.de>
>
>Split out the function virtio_snd_pcm_open() from
>virtio_snd_pcm_prepare(). A later patch also needs
>the new function. There is no functional change.
>
>Signed-off-by: Volker Rümelin <vr_qemu@t-online.de>
>[AM: trivial rebase changes]
>Signed-off-by: Alexander Mikhalitsyn <aleksandr.mikhalitsyn@futurfusion.io>
>Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
>---

Reviewed-by: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>

> hw/audio/virtio-snd.c | 60 ++++++++++++++++++++++++-------------------
> 1 file changed, 33 insertions(+), 27 deletions(-)
>
>diff --git a/hw/audio/virtio-snd.c b/hw/audio/virtio-snd.c
>index 68d737478f5..d5242a5c761 100644
>--- a/hw/audio/virtio-snd.c
>+++ b/hw/audio/virtio-snd.c
>@@ -429,6 +429,38 @@ static void virtio_snd_get_qemu_audsettings(audsettings *as,
>     as->big_endian = false; /* Conforming to VIRTIO 1.0: always little endian. */
> }
> 
>+/*
>+ * Open a stream.
>+ *
>+ * @stream: VirtIOSoundPCMStream *stream
>+ */
>+static void virtio_snd_pcm_open(VirtIOSoundPCMStream *stream)
>+{
>+    virtio_snd_get_qemu_audsettings(&stream->as, &stream->params);
>+    stream->positions[0] = VIRTIO_SND_CHMAP_FL;
>+    stream->positions[1] = VIRTIO_SND_CHMAP_FR;
>+
>+    if (stream->info.direction == VIRTIO_SND_D_OUTPUT) {
>+        stream->voice.out = audio_be_open_out(stream->s->audio_be,
>+                                         stream->voice.out,
>+                                         "virtio-sound.out",
>+                                         stream,
>+                                         virtio_snd_pcm_out_cb,
>+                                         &stream->as);
>+        audio_be_set_volume_out_lr(stream->s->audio_be,
>+                                   stream->voice.out, 0, 255, 255);
>+    } else {
>+        stream->voice.in = audio_be_open_in(stream->s->audio_be,
>+                                        stream->voice.in,
>+                                        "virtio-sound.in",
>+                                        stream,
>+                                        virtio_snd_pcm_in_cb,
>+                                        &stream->as);
>+        audio_be_set_volume_in_lr(stream->s->audio_be,
>+                                  stream->voice.in, 0, 255, 255);
>+    }
>+}
>+
> /*
>  * Close a stream and free all its resources.
>  *
>@@ -454,8 +486,6 @@ static void virtio_snd_pcm_close(VirtIOSoundPCMStream *stream)
>  */
> static uint32_t virtio_snd_pcm_prepare(VirtIOSound *s, uint32_t stream_id)
> {
>-    audsettings as;
>-    virtio_snd_pcm_set_params *params;
>     VirtIOSoundPCMStream *stream;
> 
>     stream = virtio_snd_pcm_get_stream(s, stream_id);
>@@ -472,31 +502,7 @@ static uint32_t virtio_snd_pcm_prepare(VirtIOSound *s, uint32_t stream_id)
>         return cpu_to_le32(VIRTIO_SND_S_BAD_MSG);
>     }
> 
>-    params = virtio_snd_pcm_get_params(s, stream_id);
>-
>-    virtio_snd_get_qemu_audsettings(&as, params);
>-
>-    stream->positions[0] = VIRTIO_SND_CHMAP_FL;
>-    stream->positions[1] = VIRTIO_SND_CHMAP_FR;
>-    stream->as = as;
>-
>-    if (stream->info.direction == VIRTIO_SND_D_OUTPUT) {
>-        stream->voice.out = audio_be_open_out(s->audio_be,
>-                                         stream->voice.out,
>-                                         "virtio-sound.out",
>-                                         stream,
>-                                         virtio_snd_pcm_out_cb,
>-                                         &as);
>-        audio_be_set_volume_out_lr(s->audio_be, stream->voice.out, 0, 255, 255);
>-    } else {
>-        stream->voice.in = audio_be_open_in(s->audio_be,
>-                                        stream->voice.in,
>-                                        "virtio-sound.in",
>-                                        stream,
>-                                        virtio_snd_pcm_in_cb,
>-                                        &as);
>-        audio_be_set_volume_in_lr(s->audio_be, stream->voice.in, 0, 255, 255);
>-    }
>+    virtio_snd_pcm_open(stream);
> 
>     stream->state = VSND_PCMSTREAM_STATE_PREPARED;
> 
>-- 
>2.47.3
>