Re: [PATCH v3 8/9] hw/audio/virtio-sound: remove channel positions field from VirtIOSoundPCMStream

[Manos Pitsidianakis <manos.pitsidianakis@linaro.org>]

On Fri, 26 Jun 2026 15:35, Alexander Mikhalitsyn <alexander@mihalicyn.com> wrote:
>From: Alexander Mikhalitsyn <aleksandr.mikhalitsyn@futurfusion.io>
>
>This field seems to be useless currently, as we
>don't implement VIRTIO_SND_R_CHMAP_INFO.
>
>Suggested-by: Marc-André Lureau <marcandre.lureau@redhat.com>
>Signed-off-by: Alexander Mikhalitsyn <aleksandr.mikhalitsyn@futurfusion.io>
>---

You could move this patch at the start of the series so that you don't 
need to move around lines that touch positions and then remove them.

Either way:

Reviewed-by: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>

>v3:
>	- this patch was added
>---
> hw/audio/virtio-snd.c         | 2 --
> include/hw/audio/virtio-snd.h | 2 --
> 2 files changed, 4 deletions(-)
>
>diff --git a/hw/audio/virtio-snd.c b/hw/audio/virtio-snd.c
>index c9c93bd090a..81ba1e1a277 100644
>--- a/hw/audio/virtio-snd.c
>+++ b/hw/audio/virtio-snd.c
>@@ -437,8 +437,6 @@ static void virtio_snd_get_qemu_audsettings(audsettings *as,
> static void virtio_snd_pcm_open(VirtIOSoundPCMStream *stream)
> {
>     virtio_snd_get_qemu_audsettings(&stream->as, &stream->params);
>-    stream->positions[0] = VIRTIO_SND_CHMAP_FL;
>-    stream->positions[1] = VIRTIO_SND_CHMAP_FR;
> 
>     if (stream->info.direction == VIRTIO_SND_D_OUTPUT) {
>         stream->voice.out = audio_be_open_out(stream->s->audio_be,
>diff --git a/include/hw/audio/virtio-snd.h b/include/hw/audio/virtio-snd.h
>index 72ef34e0976..85d5d7c8619 100644
>--- a/include/hw/audio/virtio-snd.h
>+++ b/include/hw/audio/virtio-snd.h
>@@ -123,8 +123,6 @@ struct VirtIOSoundPCMStream {
>     virtio_snd_pcm_info info;
>     virtio_snd_pcm_set_params params;
>     uint32_t state;
>-    /* channel position values (VIRTIO_SND_CHMAP_XXX) */
>-    uint8_t positions[VIRTIO_SND_CHMAP_MAX_SIZE];
>     VirtIOSound *s;
>     audsettings as;
>     union {
>-- 
>2.47.3
>