Re: [PATCH v3 3/4] mm: cma: add list of currently allocated CMA buffers to debugfs

[Michal Nazarewicz <mina86@mina86.com>]

On Mon, Mar 02 2015, Stefan Strogin <s.strogin@partner.samsung.com> wrote:
> My fault. You are right.
> I'm not sure how to do the output nice... I could use *ppos to point the
> number of next list entry to read (like that is used in
> read_page_owner()). But in this case the list could be changed before we
> finish reading, it's bad.
> Or we could use seq_files like in v1, iterating over buffer_list
> entries. But seq_print_stack_trace() has to be added.

I’m not that familiar with seq_* so my opinion may be ill-informed, but
I feel that skipping some entries while (de)allocations happen is akin
to process reading a file while some other process modifies it.  This is
a debug function so perhaps it’s acceptable that it may return garbage
if not used carefully?

-- 
Best regards,                                         _     _
.o. | Liege of Serenely Enlightened Majesty of      o' \,=./ `o
..o | Computer Science,  Michał “mina86” Nazarewicz    (o o)
ooo +--<mpn@google.com>--<xmpp:mina86@jabber.org>--ooO--(_)--Ooo--

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>