From: Michal Nazarewicz <mina86@mina86.com>
To: Stefan Strogin <s.strogin@partner.samsung.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Cc: Joonsoo Kim <iamjoonsoo.kim@lge.com>,
Andrew Morton <akpm@linux-foundation.org>,
Marek Szyprowski <m.szyprowski@samsung.com>,
aneesh.kumar@linux.vnet.ibm.com,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Dmitry Safonov <d.safonov@partner.samsung.com>,
Pintu Kumar <pintu.k@samsung.com>,
Weijie Yang <weijie.yang@samsung.com>,
Laura Abbott <lauraa@codeaurora.org>,
SeongJae Park <sj38.park@gmail.com>, Hui Zhu <zhuhui@xiaomi.com>,
Minchan Kim <minchan@kernel.org>,
Dyasly Sergey <s.dyasly@samsung.com>,
Vyacheslav Tyrtov <v.tyrtov@samsung.com>,
Aleksei Mateosian <a.mateosian@samsung.com>,
gregory.0xf0@gmail.com, sasha.levin@oracle.com, gioh.kim@lge.com,
pavel@ucw.cz, stefan.strogin@gmail.com
Subject: Re: [PATCH v3 2/4] mm: cma: add number of pages to debug message in cma_release()
Date: Tue, 24 Feb 2015 22:15:07 +0100 [thread overview]
Message-ID: <xa1tr3tfovtw.fsf@mina86.com> (raw)
In-Reply-To: <a0c78bd29b1aa0bccb461ebd675716c0b1a2caf3.1424802755.git.s.strogin@partner.samsung.com>
On Tue, Feb 24 2015, Stefan Strogin <s.strogin@partner.samsung.com> wrote:
> It's more useful to print address and number of pages which are being released,
> not only address.
>
> Signed-off-by: Stefan Strogin <s.strogin@partner.samsung.com>
Acked-by: Michal Nazarewicz <mina86@mina86.com>
> ---
> mm/cma.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/cma.c b/mm/cma.c
> index 3a63c96..111bf62 100644
> --- a/mm/cma.c
> +++ b/mm/cma.c
> @@ -434,7 +434,7 @@ bool cma_release(struct cma *cma, struct page *pages, int count)
> if (!cma || !pages)
> return false;
>
> - pr_debug("%s(page %p)\n", __func__, (void *)pages);
> + pr_debug("%s(page %p, count %d)\n", __func__, (void *)pages, count);
>
> pfn = page_to_pfn(pages);
>
> --
> 2.1.0
>
--
Best regards, _ _
.o. | Liege of Serenely Enlightened Majesty of o' \,=./ `o
..o | Computer Science, Michał “mina86” Nazarewicz (o o)
ooo +--<mpn@google.com>--<xmpp:mina86@jabber.org>--ooO--(_)--Ooo--
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Michal Nazarewicz <mina86@mina86.com>
To: Stefan Strogin <s.strogin@partner.samsung.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Cc: Stefan Strogin <s.strogin@partner.samsung.com>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
Andrew Morton <akpm@linux-foundation.org>,
Marek Szyprowski <m.szyprowski@samsung.com>,
aneesh.kumar@linux.vnet.ibm.com,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Dmitry Safonov <d.safonov@partner.samsung.com>,
Pintu Kumar <pintu.k@samsung.com>,
Weijie Yang <weijie.yang@samsung.com>,
Laura Abbott <lauraa@codeaurora.org>,
SeongJae Park <sj38.park@gmail.com>, Hui Zhu <zhuhui@xiaomi.com>,
Minchan Kim <minchan@kernel.org>,
Dyasly Sergey <s.dyasly@samsung.com>,
Vyacheslav Tyrtov <v.tyrtov@samsung.com>,
Aleksei Mateosian <a.mateosian@samsung.com>,
gregory.0xf0@gmail.com, sasha.levin@oracle.com, gioh.kim@lge.com,
pavel@ucw.cz, stefan.strogin@gmail.com
Subject: Re: [PATCH v3 2/4] mm: cma: add number of pages to debug message in cma_release()
Date: Tue, 24 Feb 2015 22:15:07 +0100 [thread overview]
Message-ID: <xa1tr3tfovtw.fsf@mina86.com> (raw)
In-Reply-To: <a0c78bd29b1aa0bccb461ebd675716c0b1a2caf3.1424802755.git.s.strogin@partner.samsung.com>
On Tue, Feb 24 2015, Stefan Strogin <s.strogin@partner.samsung.com> wrote:
> It's more useful to print address and number of pages which are being released,
> not only address.
>
> Signed-off-by: Stefan Strogin <s.strogin@partner.samsung.com>
Acked-by: Michal Nazarewicz <mina86@mina86.com>
> ---
> mm/cma.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/cma.c b/mm/cma.c
> index 3a63c96..111bf62 100644
> --- a/mm/cma.c
> +++ b/mm/cma.c
> @@ -434,7 +434,7 @@ bool cma_release(struct cma *cma, struct page *pages, int count)
> if (!cma || !pages)
> return false;
>
> - pr_debug("%s(page %p)\n", __func__, (void *)pages);
> + pr_debug("%s(page %p, count %d)\n", __func__, (void *)pages, count);
>
> pfn = page_to_pfn(pages);
>
> --
> 2.1.0
>
--
Best regards, _ _
.o. | Liege of Serenely Enlightened Majesty of o' \,=./ `o
..o | Computer Science, Michał “mina86” Nazarewicz (o o)
ooo +--<mpn@google.com>--<xmpp:mina86@jabber.org>--ooO--(_)--Ooo--
next prev parent reply other threads:[~2015-02-24 21:15 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-24 18:44 [PATCH v3 0/4] mm: cma: add some debug information for CMA Stefan Strogin
2015-02-24 18:44 ` Stefan Strogin
2015-02-24 18:44 ` [PATCH v3 1/4] mm: cma: add trace events to debug physically-contiguous memory allocations Stefan Strogin
2015-02-24 18:44 ` Stefan Strogin
2015-02-24 21:14 ` Michal Nazarewicz
2015-02-24 21:14 ` Michal Nazarewicz
2015-03-03 9:13 ` Aneesh Kumar K.V
2015-03-03 9:13 ` Aneesh Kumar K.V
2015-03-05 14:33 ` Stefan Strogin
2015-03-05 14:33 ` Stefan Strogin
2015-02-24 18:44 ` [PATCH v3 2/4] mm: cma: add number of pages to debug message in cma_release() Stefan Strogin
2015-02-24 18:44 ` Stefan Strogin
2015-02-24 21:15 ` Michal Nazarewicz [this message]
2015-02-24 21:15 ` Michal Nazarewicz
2015-02-24 18:44 ` [PATCH v3 3/4] mm: cma: add list of currently allocated CMA buffers to debugfs Stefan Strogin
2015-02-24 18:44 ` Stefan Strogin
2015-02-24 21:32 ` Michal Nazarewicz
2015-02-24 21:32 ` Michal Nazarewicz
2015-03-02 15:44 ` Stefan Strogin
2015-03-02 15:44 ` Stefan Strogin
2015-03-02 20:42 ` Michal Nazarewicz
2015-03-02 20:42 ` Michal Nazarewicz
2015-03-03 9:16 ` Aneesh Kumar K.V
2015-03-03 9:16 ` Aneesh Kumar K.V
2015-03-10 13:28 ` Stefan Strogin
2015-03-10 13:28 ` Stefan Strogin
2015-03-17 10:23 ` Aneesh Kumar K.V
2015-03-17 10:23 ` Aneesh Kumar K.V
2015-02-24 18:44 ` [PATCH v3 4/4] mm: cma: add functions to get region pages counters Stefan Strogin
2015-02-24 18:44 ` Stefan Strogin
2015-02-24 21:34 ` Michal Nazarewicz
2015-02-24 21:34 ` Michal Nazarewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xa1tr3tfovtw.fsf@mina86.com \
--to=mina86@mina86.com \
--cc=a.mateosian@samsung.com \
--cc=akpm@linux-foundation.org \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=d.safonov@partner.samsung.com \
--cc=gioh.kim@lge.com \
--cc=gregory.0xf0@gmail.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=lauraa@codeaurora.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=m.szyprowski@samsung.com \
--cc=minchan@kernel.org \
--cc=pavel@ucw.cz \
--cc=pintu.k@samsung.com \
--cc=s.dyasly@samsung.com \
--cc=s.strogin@partner.samsung.com \
--cc=sasha.levin@oracle.com \
--cc=sj38.park@gmail.com \
--cc=stefan.strogin@gmail.com \
--cc=v.tyrtov@samsung.com \
--cc=weijie.yang@samsung.com \
--cc=zhuhui@xiaomi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.