All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "brian m. carlson" <sandals@crustytoothpaste.net>
Cc: "Patrick Steinhardt" <ps@pks.im>,
	git@vger.kernel.org, "Elijah Newren" <newren@gmail.com>,
	"Derrick Stolee" <stolee@gmail.com>,
	"SZEDER Gábor" <szeder.dev@gmail.com>,
	"Johannes Schindelin" <Johannes.Schindelin@gmx.de>,
	"Phillip Wood" <phillip.wood@dunelm.org.uk>
Subject: Re: [PATCH RFC v3 2/2] Move libgit.a sources into separate "lib/" directory
Date: Mon, 20 Jul 2026 15:43:50 -0700	[thread overview]
Message-ID: <xmqqqzkx9t95.fsf@gitster.g> (raw)
In-Reply-To: <al6Yz_QMlyU1GETv@fruit.crustytoothpaste.net> (brian m. carlson's message of "Mon, 20 Jul 2026 21:53:20 +0000")

"brian m. carlson" <sandals@crustytoothpaste.net> writes:

> I would very much welcome better rename support and I'm sure the
> community would as well.  If we can incentivize ourselves to step up and
> implement that, I'm all for it.

I would welcome such an effort.  It is, however, a different story
to move things simply because we want to move them, without a
concrete need or strategy to do so.

In any case, the root level of the 'lib/' directory introduced by
the 'ps/libgit-in-subdir' topic is full of source files, with only a
small number of focused subdirectories like 'odb/', 'refs/', and
'ewah/' mixed in to house specific subsystems.  This merely shifts
the clutter one level down without resolving it.

I would rather see a structure where each subsystem-like group
carves out its own directory.

I do not particularly care whether such a directory lives at the
root level or inside 'lib/'.  But if we were to establish a sensible
grouping, I suspect we would not need a 'lib/' directory solely to
house the 'refs/' and 'odb/' subdirectories.  Instead, it would be
sufficiently clean to have 'refs/', 'odb/', and other subsystem
directories directly under the root level.

I do not think we want to do this in a single large change.  If we
were to move everything to 'lib/' only to then need to further group
them into subdirectories of 'lib/', it would subject us to multiple
rounds of disruption.  I suspect it would be far less disruptive if
we migrated one subsystem at a time, directly to a new directory
immediately below the root level.

  reply	other threads:[~2026-07-20 22:43 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-16 13:24 [PATCH RFC 0/2] Move libgit.a sources into separate "lib/" directory Patrick Steinhardt
2026-04-16 13:24 ` [PATCH RFC 1/2] t/helper: prepare "test-example-tap.c" for introduction of "lib/" Patrick Steinhardt
2026-04-16 13:24 ` [PATCH RFC 2/2] Move libgit.a sources into separate "lib/" directory Patrick Steinhardt
2026-04-17 17:08   ` Elijah Newren
2026-04-17 19:18   ` brian m. carlson
2026-04-17 21:18     ` Junio C Hamano
2026-04-17 21:51       ` brian m. carlson
2026-04-20  6:41         ` Patrick Steinhardt
2026-04-19 14:11 ` [PATCH RFC 0/2] " Phillip Wood
2026-04-20  6:41   ` Patrick Steinhardt
2026-04-20 12:03 ` Derrick Stolee
2026-04-21  5:55   ` Patrick Steinhardt
2026-04-21 14:13     ` Derrick Stolee
2026-04-22  6:39       ` Patrick Steinhardt
2026-06-22 10:38 ` [PATCH RFC v2 " Patrick Steinhardt
2026-06-22 10:38   ` [PATCH RFC v2 1/2] t/helper: prepare "test-example-tap.c" for introduction of "lib/" Patrick Steinhardt
2026-06-22 10:38   ` [PATCH RFC v2 2/2] Move libgit.a sources into separate "lib/" directory Patrick Steinhardt
2026-06-22 13:08     ` Junio C Hamano
2026-06-24 10:32       ` Patrick Steinhardt
2026-06-24 11:23       ` Oswald Buddenhagen
2026-06-26 16:01     ` Johannes Schindelin
2026-06-26 18:50       ` Junio C Hamano
2026-07-01  6:54       ` Patrick Steinhardt
2026-06-27  6:40     ` SZEDER Gábor
2026-07-01  6:55       ` Patrick Steinhardt
2026-07-01 13:26         ` Phillip Wood
2026-07-01 14:45           ` Junio C Hamano
2026-07-02  5:21             ` Patrick Steinhardt
2026-07-06  4:29               ` Kaartic Sivaraam
2026-07-01  6:59 ` [PATCH RFC v3 0/2] " Patrick Steinhardt
2026-07-01  6:59   ` [PATCH RFC v3 1/2] t/helper: prepare "test-example-tap.c" for introduction of "lib/" Patrick Steinhardt
2026-07-01  6:59   ` [PATCH RFC v3 2/2] Move libgit.a sources into separate "lib/" directory Patrick Steinhardt
2026-07-13  5:52     ` SZEDER Gábor
2026-07-20 14:24       ` Johannes Schindelin
2026-07-20 22:14         ` Junio C Hamano
2026-07-20 21:53     ` brian m. carlson
2026-07-20 22:43       ` Junio C Hamano [this message]
2026-07-20 23:40         ` Taylor Blau
2026-07-13  5:50 ` [PATCH RFC v4 0/2] " Patrick Steinhardt
2026-07-13  5:50   ` [PATCH RFC v4 1/2] t/helper: prepare "test-example-tap.c" for introduction of "lib/" Patrick Steinhardt
2026-07-13  5:50   ` [PATCH RFC v4 2/2] Move libgit.a sources into separate "lib/" directory Patrick Steinhardt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqqzkx9t95.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=newren@gmail.com \
    --cc=phillip.wood@dunelm.org.uk \
    --cc=ps@pks.im \
    --cc=sandals@crustytoothpaste.net \
    --cc=stolee@gmail.com \
    --cc=szeder.dev@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.