* [PATCH] typofix: fix spelling mistakes in comments and test description
@ 2026-08-30 13:42 Hardik Kumar
2026-08-30 16:23 ` Michael Montalbo
2026-08-31 17:41 ` Junio C Hamano
0 siblings, 2 replies; 4+ messages in thread
From: Hardik Kumar @ 2026-08-30 13:42 UTC (permalink / raw)
To: git; +Cc: Hardik Kumar
Fix spelling errors in the following places:
versioncmp.c: "fractionnal" -> "fractional"
git-gui/git-gui.sh: "occurence" -> "occurrence"
t/t0022-crlf-rename.sh: "similiarity" -> "similarity"
Signed-off-by: Hardik Kumar <hardikxk@gmail.com>
---
git-gui/git-gui.sh | 2 +-
t/t0022-crlf-rename.sh | 2 +-
versioncmp.c | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/git-gui/git-gui.sh b/git-gui/git-gui.sh
index 15dd2b3a84..cc8a05517a 100755
--- a/git-gui/git-gui.sh
+++ b/git-gui/git-gui.sh
@@ -109,7 +109,7 @@ foreach p [split $env(PATH) $_path_sep] {
if {[file pathtype $p] ne {absolute}} {
continue
}
- # Keep only the first occurence of any duplicates.
+ # Keep only the first occurrence of any duplicates.
set norm_p [file normalize $p]
dict set _path_seen $norm_p 1
}
diff --git a/t/t0022-crlf-rename.sh b/t/t0022-crlf-rename.sh
index 9bd863a970..328c6e5903 100755
--- a/t/t0022-crlf-rename.sh
+++ b/t/t0022-crlf-rename.sh
@@ -1,6 +1,6 @@
#!/bin/sh
-test_description='ignore CR in CRLF sequence while computing similiarity'
+test_description='ignore CR in CRLF sequence while computing similarity'
. ./test-lib.sh
diff --git a/versioncmp.c b/versioncmp.c
index 3a81b17bc1..f1e451755a 100644
--- a/versioncmp.c
+++ b/versioncmp.c
@@ -15,7 +15,7 @@
/*
* states: S_N: normal, S_I: comparing integral part, S_F: comparing
- * fractionnal parts, S_Z: idem but with leading Zeroes only
+ * fractional parts, S_Z: idem but with leading Zeroes only
*/
#define S_N 0x0
#define S_I 0x3
---
base-commit: c73e85354c275c9d409b26445089bc16940fc527
change-id: 20260830-typo-fea59ea5a02a
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] typofix: fix spelling mistakes in comments and test description
2026-08-30 13:42 [PATCH] typofix: fix spelling mistakes in comments and test description Hardik Kumar
@ 2026-08-30 16:23 ` Michael Montalbo
2026-08-31 17:41 ` Junio C Hamano
1 sibling, 0 replies; 4+ messages in thread
From: Michael Montalbo @ 2026-08-30 16:23 UTC (permalink / raw)
To: Hardik Kumar; +Cc: git
On Sun, Aug 30, 2026 at 6:42 AM Hardik Kumar <hardikxk@gmail.com> wrote:
>
> Fix spelling errors in the following places:
>
> versioncmp.c: "fractionnal" -> "fractional"
> git-gui/git-gui.sh: "occurence" -> "occurrence"
> t/t0022-crlf-rename.sh: "similiarity" -> "similarity"
>
> Signed-off-by: Hardik Kumar <hardikxk@gmail.com>
These changes LGTM.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] typofix: fix spelling mistakes in comments and test description
2026-08-30 13:42 [PATCH] typofix: fix spelling mistakes in comments and test description Hardik Kumar
2026-08-30 16:23 ` Michael Montalbo
@ 2026-08-31 17:41 ` Junio C Hamano
2026-08-31 17:56 ` Hardik Kumar
1 sibling, 1 reply; 4+ messages in thread
From: Junio C Hamano @ 2026-08-31 17:41 UTC (permalink / raw)
To: Hardik Kumar; +Cc: git
Hardik Kumar <hardikxk@gmail.com> writes:
> Fix spelling errors in the following places:
>
> versioncmp.c: "fractionnal" -> "fractional"
> git-gui/git-gui.sh: "occurence" -> "occurrence"
> t/t0022-crlf-rename.sh: "similiarity" -> "similarity"
git-gui comes from a separate project and a different rule applies
to patches in that area. See Documentation/SubmittingPatches for
details, but the consequences to the rule are:
- Any patch to git-gui (or gitk) would not be a patch against a path
inside git-gui/ (or gitk-git/) directory.
- A patch message to git-gui (or gitk) would not contain any
patches to other parts of the system.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] typofix: fix spelling mistakes in comments and test description
2026-08-31 17:41 ` Junio C Hamano
@ 2026-08-31 17:56 ` Hardik Kumar
0 siblings, 0 replies; 4+ messages in thread
From: Hardik Kumar @ 2026-08-31 17:56 UTC (permalink / raw)
To: Junio C Hamano, Hardik Kumar; +Cc: git
On Mon Aug 31, 2026 at 11:11 PM IST, Junio C Hamano wrote:
> Hardik Kumar <hardikxk@gmail.com> writes:
>
>> Fix spelling errors in the following places:
>>
>> versioncmp.c: "fractionnal" -> "fractional"
>> git-gui/git-gui.sh: "occurence" -> "occurrence"
>> t/t0022-crlf-rename.sh: "similiarity" -> "similarity"
>
> git-gui comes from a separate project and a different rule applies
> to patches in that area. See Documentation/SubmittingPatches for
> details, but the consequences to the rule are:
>
> - Any patch to git-gui (or gitk) would not be a patch against a path
> inside git-gui/ (or gitk-git/) directory.
>
> - A patch message to git-gui (or gitk) would not contain any
> patches to other parts of the system.
Thank you I had skipped over that.
I had sent another patch with the "versioncmp" prefix which only edits
the core files to fix the typos.
Thanks.
Hardik
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-08-31 17:56 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-08-30 13:42 [PATCH] typofix: fix spelling mistakes in comments and test description Hardik Kumar
2026-08-30 16:23 ` Michael Montalbo
2026-08-31 17:41 ` Junio C Hamano
2026-08-31 17:56 ` Hardik Kumar
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.