From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: "brian m. carlson" <sandals@crustytoothpaste.net>, git@vger.kernel.org
Subject: Re: [PATCH v3 0/4] parseopt: exit 0 on help
Date: Wed, 08 Jul 2026 13:32:00 -0700 [thread overview]
Message-ID: <xmqqzf01rznj.fsf@gitster.g> (raw)
In-Reply-To: <20260708035930.GB41684@coredump.intra.peff.net> (Jeff King's message of "Tue, 7 Jul 2026 23:59:30 -0400")
Jeff King <peff@peff.net> writes:
> On Wed, Jul 08, 2026 at 12:15:53AM +0000, brian m. carlson wrote:
>
>> Changes since v2:
>>
>> * Fix inverted condition in t1517.
>> * Stop checking for old versions of SVN Perl libraries since they are
>> so old nobody is using them.
>> * Adjust the various cases where we choose between the error and
>> non-error help output.
>
> Thanks, I have no complaints on this version.
>
> In the earlier thread I sketched out a hypothetical caller that might be
> affected by the change, but beyond raw speculation, I don't think we
> have any way of knowing how common such a thing is. So I'm inclined to
> proceed and see if anybody screams during this development cycle.
;-) 100% agreed on the issue of possible regressions.
prev parent reply other threads:[~2026-07-08 20:32 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-15 0:52 Unexpected exit code for --help with rev-parse --parseopt brian m. carlson
2026-03-15 3:14 ` Jeff King
2026-03-15 16:59 ` brian m. carlson
2026-03-15 18:16 ` Jeff King
2026-03-16 22:07 ` [PATCH] rev-parse: have --parseopt callers exit 0 on --help brian m. carlson
2026-03-17 0:47 ` Junio C Hamano
2026-03-17 11:59 ` brian m. carlson
2026-03-17 14:55 ` Jeff King
2026-03-17 15:07 ` Jeff King
2026-03-17 17:06 ` Junio C Hamano
2026-03-17 18:44 ` Jeff King
2026-03-18 0:24 ` brian m. carlson
2026-03-18 1:22 ` Jeff King
2026-03-18 2:45 ` Junio C Hamano
2026-07-01 21:24 ` [PATCH v2 0/4] rev-parse: " brian m. carlson
2026-07-01 21:24 ` [PATCH v2 1/4] t1517: skip svn tests if svn is not installed brian m. carlson
2026-07-01 22:10 ` Junio C Hamano
2026-07-01 22:27 ` Junio C Hamano
2026-07-02 14:47 ` [PATCH v2 1/4] t1517: skip svn tests if svn is not installed2sy brian m. carlson
2026-07-02 5:37 ` [PATCH v2 1/4] t1517: skip svn tests if svn is not installed Jeff King
2026-07-03 20:36 ` Junio C Hamano
2026-07-04 4:47 ` Jeff King
2026-07-01 21:24 ` [PATCH v2 2/4] parse-options: add a separate case for help output on error brian m. carlson
2026-07-02 8:38 ` Jeff King
2026-07-01 21:24 ` [PATCH v2 3/4] rev-parse: have --parseopt callers exit 0 on --help brian m. carlson
2026-07-01 22:16 ` Junio C Hamano
2026-07-01 21:24 ` [PATCH v2 4/4] parse-options: exit 0 on -h brian m. carlson
2026-07-01 22:06 ` [PATCH v2 0/4] rev-parse: exit 0 on --help Junio C Hamano
2026-07-02 8:45 ` Jeff King
2026-07-03 20:38 ` Junio C Hamano
2026-07-08 0:15 ` [PATCH v3 0/4] parseopt: exit 0 on help brian m. carlson
2026-07-08 0:15 ` [PATCH v3 1/4] t1517: skip svn tests if svn is not installed brian m. carlson
2026-07-08 1:28 ` Junio C Hamano
2026-07-08 0:15 ` [PATCH v3 2/4] parse-options: add a separate case for help output on error brian m. carlson
2026-07-08 1:26 ` Junio C Hamano
2026-07-08 0:15 ` [PATCH v3 3/4] rev-parse: have --parseopt callers exit 0 on --help brian m. carlson
2026-07-08 0:15 ` [PATCH v3 4/4] parse-options: exit 0 on -h brian m. carlson
2026-07-08 3:59 ` [PATCH v3 0/4] parseopt: exit 0 on help Jeff King
2026-07-08 20:32 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqzf01rznj.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
--cc=sandals@crustytoothpaste.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.