From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Colin King <colin.king@canonical.com>
Cc: Jack Wang <jinpu.wang@cloud.ionos.com>,
"James E . J . Bottomley" <jejb@linux.ibm.com>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi: pm80xx: remove redundant assignments to variable rc
Date: Thu, 08 Aug 2019 02:16:41 +0000 [thread overview]
Message-ID: <yq17e7ocsfq.fsf@oracle.com> (raw)
In-Reply-To: <20190731222214.15720-1-colin.king@canonical.com> (Colin King's message of "Wed, 31 Jul 2019 23:22:14 +0100")
Colin,
> There are several occasions where variable rc is being initialized
> with a value that is never read and error is being re-assigned a
> little later on. Clean up the code by removing rc entirely and
> just returning the return value from the call to pm8001_issue_ssp_tmf
Applied to 5.4/scsi-queue. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
WARNING: multiple messages have this Message-ID (diff)
From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Colin King <colin.king@canonical.com>
Cc: Jack Wang <jinpu.wang@cloud.ionos.com>,
"James E . J . Bottomley" <jejb@linux.ibm.com>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi: pm80xx: remove redundant assignments to variable rc
Date: Wed, 07 Aug 2019 22:16:41 -0400 [thread overview]
Message-ID: <yq17e7ocsfq.fsf@oracle.com> (raw)
In-Reply-To: <20190731222214.15720-1-colin.king@canonical.com> (Colin King's message of "Wed, 31 Jul 2019 23:22:14 +0100")
Colin,
> There are several occasions where variable rc is being initialized
> with a value that is never read and error is being re-assigned a
> little later on. Clean up the code by removing rc entirely and
> just returning the return value from the call to pm8001_issue_ssp_tmf
Applied to 5.4/scsi-queue. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2019-08-08 2:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-31 22:22 [PATCH] scsi: pm80xx: remove redundant assignments to variable rc Colin King
2019-07-31 22:22 ` Colin King
2019-08-01 7:07 ` Jinpu Wang
2019-08-01 7:07 ` Jinpu Wang
2019-08-08 2:16 ` Martin K. Petersen [this message]
2019-08-08 2:16 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq17e7ocsfq.fsf@oracle.com \
--to=martin.petersen@oracle.com \
--cc=colin.king@canonical.com \
--cc=jejb@linux.ibm.com \
--cc=jinpu.wang@cloud.ionos.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.