* [PATCH -next] scsi: csiostor: Remove set but not used variable 'pln'
@ 2019-01-25 1:57 YueHaibing
2019-01-29 15:41 ` Varun Prakash
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: YueHaibing @ 2019-01-25 1:57 UTC (permalink / raw)
To: kernel-janitors
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/scsi/csiostor/csio_attr.c: In function 'csio_fcoe_free_vnp':
drivers/scsi/csiostor/csio_attr.c:500:21: warning:
variable 'pln' set but not used [-Wunused-but-set-variable]
It never used since introduction.
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/scsi/csiostor/csio_attr.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/scsi/csiostor/csio_attr.c b/drivers/scsi/csiostor/csio_attr.c
index 9bd2bd8..200e500 100644
--- a/drivers/scsi/csiostor/csio_attr.c
+++ b/drivers/scsi/csiostor/csio_attr.c
@@ -497,7 +497,6 @@
static int
csio_fcoe_free_vnp(struct csio_hw *hw, struct csio_lnode *ln)
{
- struct csio_lnode *pln;
struct csio_mb *mbp;
struct fw_fcoe_vnp_cmd *rsp;
int ret = 0;
@@ -514,8 +513,6 @@
goto out;
}
- pln = ln->pln;
-
csio_fcoe_vnp_free_init_mb(ln, mbp, CSIO_MB_DEFAULT_TMO,
ln->fcf_flowid, ln->vnp_flowid,
NULL);
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH -next] scsi: csiostor: Remove set but not used variable 'pln'
2019-01-25 1:57 [PATCH -next] scsi: csiostor: Remove set but not used variable 'pln' YueHaibing
@ 2019-01-29 15:41 ` Varun Prakash
2019-02-01 23:20 ` Martin K. Petersen
2019-10-29 6:15 ` YueHaibing
2 siblings, 0 replies; 7+ messages in thread
From: Varun Prakash @ 2019-01-29 15:41 UTC (permalink / raw)
To: kernel-janitors
On Fri, Jan 25, 2019 at 01:57:19AM +0000, YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/scsi/csiostor/csio_attr.c: In function 'csio_fcoe_free_vnp':
> drivers/scsi/csiostor/csio_attr.c:500:21: warning:
> variable 'pln' set but not used [-Wunused-but-set-variable]
>
> It never used since introduction.
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> drivers/scsi/csiostor/csio_attr.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/scsi/csiostor/csio_attr.c b/drivers/scsi/csiostor/csio_attr.c
> index 9bd2bd8..200e500 100644
> --- a/drivers/scsi/csiostor/csio_attr.c
> +++ b/drivers/scsi/csiostor/csio_attr.c
> @@ -497,7 +497,6 @@
> static int
> csio_fcoe_free_vnp(struct csio_hw *hw, struct csio_lnode *ln)
> {
> - struct csio_lnode *pln;
> struct csio_mb *mbp;
> struct fw_fcoe_vnp_cmd *rsp;
> int ret = 0;
> @@ -514,8 +513,6 @@
> goto out;
> }
>
> - pln = ln->pln;
> -
> csio_fcoe_vnp_free_init_mb(ln, mbp, CSIO_MB_DEFAULT_TMO,
> ln->fcf_flowid, ln->vnp_flowid,
> NULL);
>
>
Acked-by: Varun Prakash <varun@chelsio.com>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH -next] scsi: csiostor: Remove set but not used variable 'pln'
2019-01-25 1:57 [PATCH -next] scsi: csiostor: Remove set but not used variable 'pln' YueHaibing
2019-01-29 15:41 ` Varun Prakash
@ 2019-02-01 23:20 ` Martin K. Petersen
2019-10-29 6:15 ` YueHaibing
2 siblings, 0 replies; 7+ messages in thread
From: Martin K. Petersen @ 2019-02-01 23:20 UTC (permalink / raw)
To: kernel-janitors
YueHaibing,
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/scsi/csiostor/csio_attr.c: In function 'csio_fcoe_free_vnp':
> drivers/scsi/csiostor/csio_attr.c:500:21: warning:
> variable 'pln' set but not used [-Wunused-but-set-variable]
Applied to 5.1/scsi-queue. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH -next] scsi: csiostor: Remove set but not used variable 'rln'
@ 2019-10-29 6:15 ` YueHaibing
0 siblings, 0 replies; 7+ messages in thread
From: YueHaibing @ 2019-10-29 6:15 UTC (permalink / raw)
To: James E . J . Bottomley, Martin K. Petersen, Dan Carpenter
Cc: YueHaibing, linux-scsi, linux-kernel, kernel-janitors
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/scsi/csiostor/csio_lnode.c: In function 'csio_ln_init':
drivers/scsi/csiostor/csio_lnode.c:1995:21: warning:
variable 'rln' set but not used [-Wunused-but-set-variable]
It is never used since introduction, so remove it.
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/scsi/csiostor/csio_lnode.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/scsi/csiostor/csio_lnode.c b/drivers/scsi/csiostor/csio_lnode.c
index 23cbe4cda760..74ff8adc41f7 100644
--- a/drivers/scsi/csiostor/csio_lnode.c
+++ b/drivers/scsi/csiostor/csio_lnode.c
@@ -1992,7 +1992,7 @@ static int
csio_ln_init(struct csio_lnode *ln)
{
int rv = -EINVAL;
- struct csio_lnode *rln, *pln;
+ struct csio_lnode *pln;
struct csio_hw *hw = csio_lnode_to_hw(ln);
csio_init_state(&ln->sm, csio_lns_uninit);
@@ -2022,7 +2022,6 @@ csio_ln_init(struct csio_lnode *ln)
* THe rest is common for non-root physical and NPIV lnodes.
* Just get references to all other modules
*/
- rln = csio_root_lnode(ln);
if (csio_is_npiv_ln(ln)) {
/* NPIV */
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH -next] scsi: csiostor: Remove set but not used variable 'rln'
@ 2019-10-29 6:15 ` YueHaibing
0 siblings, 0 replies; 7+ messages in thread
From: YueHaibing @ 2019-10-29 6:15 UTC (permalink / raw)
To: James E . J . Bottomley, Martin K. Petersen, Dan Carpenter
Cc: YueHaibing, linux-scsi, linux-kernel, kernel-janitors
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/scsi/csiostor/csio_lnode.c: In function 'csio_ln_init':
drivers/scsi/csiostor/csio_lnode.c:1995:21: warning:
variable 'rln' set but not used [-Wunused-but-set-variable]
It is never used since introduction, so remove it.
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/scsi/csiostor/csio_lnode.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/scsi/csiostor/csio_lnode.c b/drivers/scsi/csiostor/csio_lnode.c
index 23cbe4cda760..74ff8adc41f7 100644
--- a/drivers/scsi/csiostor/csio_lnode.c
+++ b/drivers/scsi/csiostor/csio_lnode.c
@@ -1992,7 +1992,7 @@ static int
csio_ln_init(struct csio_lnode *ln)
{
int rv = -EINVAL;
- struct csio_lnode *rln, *pln;
+ struct csio_lnode *pln;
struct csio_hw *hw = csio_lnode_to_hw(ln);
csio_init_state(&ln->sm, csio_lns_uninit);
@@ -2022,7 +2022,6 @@ csio_ln_init(struct csio_lnode *ln)
* THe rest is common for non-root physical and NPIV lnodes.
* Just get references to all other modules
*/
- rln = csio_root_lnode(ln);
if (csio_is_npiv_ln(ln)) {
/* NPIV */
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH -next] scsi: csiostor: Remove set but not used variable 'rln'
2019-10-29 6:15 ` YueHaibing
@ 2019-11-13 2:29 ` Martin K. Petersen
-1 siblings, 0 replies; 7+ messages in thread
From: Martin K. Petersen @ 2019-11-13 2:29 UTC (permalink / raw)
To: YueHaibing
Cc: James E . J . Bottomley, Martin K. Petersen, Dan Carpenter,
linux-scsi, linux-kernel, kernel-janitors
YueHaibing,
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/scsi/csiostor/csio_lnode.c: In function 'csio_ln_init':
> drivers/scsi/csiostor/csio_lnode.c:1995:21: warning:
> variable 'rln' set but not used [-Wunused-but-set-variable]
>
> It is never used since introduction, so remove it.
Applied to 5.5/scsi-queue, thanks.
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH -next] scsi: csiostor: Remove set but not used variable 'rln'
@ 2019-11-13 2:29 ` Martin K. Petersen
0 siblings, 0 replies; 7+ messages in thread
From: Martin K. Petersen @ 2019-11-13 2:29 UTC (permalink / raw)
To: YueHaibing
Cc: James E . J . Bottomley, Martin K. Petersen, Dan Carpenter,
linux-scsi, linux-kernel, kernel-janitors
YueHaibing,
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/scsi/csiostor/csio_lnode.c: In function 'csio_ln_init':
> drivers/scsi/csiostor/csio_lnode.c:1995:21: warning:
> variable 'rln' set but not used [-Wunused-but-set-variable]
>
> It is never used since introduction, so remove it.
Applied to 5.5/scsi-queue, thanks.
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2019-11-13 2:30 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-01-25 1:57 [PATCH -next] scsi: csiostor: Remove set but not used variable 'pln' YueHaibing
2019-01-29 15:41 ` Varun Prakash
2019-02-01 23:20 ` Martin K. Petersen
2019-10-29 6:15 ` [PATCH -next] scsi: csiostor: Remove set but not used variable 'rln' YueHaibing
2019-10-29 6:15 ` YueHaibing
2019-11-13 2:29 ` Martin K. Petersen
2019-11-13 2:29 ` Martin K. Petersen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.