From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Colin King <colin.king@canonical.com>
Cc: James Smart <james.smart@broadcom.com>,
Dick Kennedy <dick.kennedy@broadcom.com>,
"James E . J . Bottomley" <jejb@linux.vnet.ibm.com>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi: lpfc: make a couple of functions static
Date: Tue, 13 Jun 2017 01:05:29 +0000 [thread overview]
Message-ID: <yq1poe8zoh2.fsf@oracle.com> (raw)
In-Reply-To: <20170518093524.13549-1-colin.king@canonical.com> (Colin King's message of "Thu, 18 May 2017 10:35:24 +0100")
Colin,
> functions lpfc_nvmet_cleanup_io_context and
> lpfc_nvmet_setup_io_context can be made static as they do not need to
> be in global scope.
>
> Cleans up sparse warnings:
> "warning: symbol 'lpfc_nvmet_cleanup_io_context' was not declared.
> Should it be static?"
> "warning: symbol 'lpfc_nvmet_setup_io_context' was not declared.
> Should it be static?"
Applied to 4.13/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux Engineering
WARNING: multiple messages have this Message-ID (diff)
From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Colin King <colin.king@canonical.com>
Cc: James Smart <james.smart@broadcom.com>,
Dick Kennedy <dick.kennedy@broadcom.com>,
"James E . J . Bottomley" <jejb@linux.vnet.ibm.com>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi: lpfc: make a couple of functions static
Date: Mon, 12 Jun 2017 21:05:29 -0400 [thread overview]
Message-ID: <yq1poe8zoh2.fsf@oracle.com> (raw)
In-Reply-To: <20170518093524.13549-1-colin.king@canonical.com> (Colin King's message of "Thu, 18 May 2017 10:35:24 +0100")
Colin,
> functions lpfc_nvmet_cleanup_io_context and
> lpfc_nvmet_setup_io_context can be made static as they do not need to
> be in global scope.
>
> Cleans up sparse warnings:
> "warning: symbol 'lpfc_nvmet_cleanup_io_context' was not declared.
> Should it be static?"
> "warning: symbol 'lpfc_nvmet_setup_io_context' was not declared.
> Should it be static?"
Applied to 4.13/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2017-06-13 1:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-18 9:35 [PATCH] scsi: lpfc: make a couple of functions static Colin King
2017-05-18 9:35 ` Colin King
2017-05-29 23:08 ` James Smart
2017-05-29 23:08 ` James Smart
2017-06-13 1:05 ` Martin K. Petersen [this message]
2017-06-13 1:05 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1poe8zoh2.fsf@oracle.com \
--to=martin.petersen@oracle.com \
--cc=colin.king@canonical.com \
--cc=dick.kennedy@broadcom.com \
--cc=james.smart@broadcom.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.