From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Brian King <brking@linux.vnet.ibm.com>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
linux-scsi@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
linuxppc dev list <linuxppc-dev@lists.ozlabs.org>
Subject: Re: [PATCH] scsi/ipr: Fix runaway IRQs when falling back from MSI to LSI
Date: Tue, 29 Nov 2016 11:58:38 -0500 [thread overview]
Message-ID: <yq1wpfmmddt.fsf@sermon.lab.mkp.net> (raw)
In-Reply-To: <1479947042.10230.88.camel@kernel.crashing.org> (Benjamin Herrenschmidt's message of "Thu, 24 Nov 2016 11:24:02 +1100")
>>>>> "Benjamin" == Benjamin Herrenschmidt <benh@kernel.crashing.org> writes:
Benjamin> LSIs must be ack'ed with an MMIO otherwise they remain
Benjamin> asserted forever. This is controlled by the "clear_isr" flag.
Benjamin> While we set that flag properly when deciding initially
Benjamin> whether to use LSIs or MSIs, we fail to set it if we first
Benjamin> chose MSIs, the test fails, then fallback to LSIs.
Brian: Please review!
--
Martin K. Petersen Oracle Linux Engineering
WARNING: multiple messages have this Message-ID (diff)
From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Brian King <brking@linux.vnet.ibm.com>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
linux-scsi@vger.kernel.org,
"linux-kernel\@vger.kernel.org" <linux-kernel@vger.kernel.org>,
linuxppc dev list <linuxppc-dev@lists.ozlabs.org>
Subject: Re: [PATCH] scsi/ipr: Fix runaway IRQs when falling back from MSI to LSI
Date: Tue, 29 Nov 2016 11:58:38 -0500 [thread overview]
Message-ID: <yq1wpfmmddt.fsf@sermon.lab.mkp.net> (raw)
In-Reply-To: <1479947042.10230.88.camel@kernel.crashing.org> (Benjamin Herrenschmidt's message of "Thu, 24 Nov 2016 11:24:02 +1100")
>>>>> "Benjamin" == Benjamin Herrenschmidt <benh@kernel.crashing.org> writes:
Benjamin> LSIs must be ack'ed with an MMIO otherwise they remain
Benjamin> asserted forever. This is controlled by the "clear_isr" flag.
Benjamin> While we set that flag properly when deciding initially
Benjamin> whether to use LSIs or MSIs, we fail to set it if we first
Benjamin> chose MSIs, the test fails, then fallback to LSIs.
Brian: Please review!
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2016-11-29 16:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-24 0:24 [PATCH] scsi/ipr: Fix runaway IRQs when falling back from MSI to LSI Benjamin Herrenschmidt
2016-11-29 16:58 ` Martin K. Petersen [this message]
2016-11-29 16:58 ` Martin K. Petersen
2016-11-30 21:28 ` Brian King
2016-12-01 0:58 ` Martin K. Petersen
2016-12-01 0:58 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1wpfmmddt.fsf@sermon.lab.mkp.net \
--to=martin.petersen@oracle.com \
--cc=benh@kernel.crashing.org \
--cc=brking@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.