From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: "Tobin C. Harding" <tobin@apporbit.com>,
Arthur Marsh <arthur.marsh@internode.on.net>,
Salvatore Mesoraca <s.mesoraca16@gmail.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Kernel Hardening <kernel-hardening@lists.openwall.com>,
Linux SCSI List <linux-scsi@vger.kernel.org>,
"James E.J. Bottomley" <jejb@linux.vnet.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Dario Ballabio <ballabio_dario@emc.com>,
Kees Cook <keescook@chromium.org>,
kernelnewbies@kernelnewbies.org
Subject: Re: [PATCH] scsi: eata: drop VLA in reorder()
Date: Mon, 12 Mar 2018 22:35:36 -0400 [thread overview]
Message-ID: <yq1y3iwem87.fsf@oracle.com> (raw)
In-Reply-To: <CA+55aFww=otC4Wv40enadF+9NAyWG4Hotzjvv2EKb+_wGFui-w@mail.gmail.com> (Linus Torvalds's message of "Mon, 12 Mar 2018 11:45:53 -0700")
Linus,
> That said, I wonder if the solution to this particular driver is
> "delete it". Because the hardware is truly ancient and nobody sane
> would use it any more.
I'm not aware of anybody actively using these anymore. They are
mid-nineties vintage with an M68K processor onboard. I ran a couple of
these when they were new but haven't had a working board in probably a
decade.
No objections to Salvatore's patch but I have a slight affinity for
retiring unused code over patching it. So unless there are objections...
--
Martin K. Petersen Oracle Linux Engineering
WARNING: multiple messages have this Message-ID (diff)
From: martin.petersen@oracle.com (Martin K. Petersen)
To: kernelnewbies@lists.kernelnewbies.org
Subject: [PATCH] scsi: eata: drop VLA in reorder()
Date: Mon, 12 Mar 2018 22:35:36 -0400 [thread overview]
Message-ID: <yq1y3iwem87.fsf@oracle.com> (raw)
In-Reply-To: <CA+55aFww=otC4Wv40enadF+9NAyWG4Hotzjvv2EKb+_wGFui-w@mail.gmail.com> (Linus Torvalds's message of "Mon, 12 Mar 2018 11:45:53 -0700")
Linus,
> That said, I wonder if the solution to this particular driver is
> "delete it". Because the hardware is truly ancient and nobody sane
> would use it any more.
I'm not aware of anybody actively using these anymore. They are
mid-nineties vintage with an M68K processor onboard. I ran a couple of
these when they were new but haven't had a working board in probably a
decade.
No objections to Salvatore's patch but I have a slight affinity for
retiring unused code over patching it. So unless there are objections...
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2018-03-13 2:35 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-11 21:06 [PATCH] scsi: eata: drop VLA in reorder() Salvatore Mesoraca
2018-03-12 3:08 ` Tobin C. Harding
2018-03-12 3:08 ` Tobin C. Harding
2018-03-12 6:36 ` valdis.kletnieks
2018-03-12 6:36 ` valdis.kletnieks
2018-03-12 6:36 ` valdis.kletnieks at vt.edu
2018-03-12 10:11 ` Salvatore Mesoraca
2018-03-12 10:11 ` Salvatore Mesoraca
2018-03-12 18:45 ` Linus Torvalds
2018-03-12 18:45 ` Linus Torvalds
2018-03-13 0:44 ` Arthur Marsh
2018-03-13 0:44 ` Arthur Marsh
2018-03-13 0:44 ` Arthur Marsh
2018-03-13 2:35 ` Martin K. Petersen [this message]
2018-03-13 2:35 ` Martin K. Petersen
2018-03-13 9:05 ` Christoph Hellwig
2018-03-13 9:05 ` Christoph Hellwig
2018-03-13 22:04 ` Salvatore Mesoraca
2018-03-13 22:04 ` Salvatore Mesoraca
2018-03-13 22:04 ` Salvatore Mesoraca
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1y3iwem87.fsf@oracle.com \
--to=martin.petersen@oracle.com \
--cc=arthur.marsh@internode.on.net \
--cc=ballabio_dario@emc.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=keescook@chromium.org \
--cc=kernel-hardening@lists.openwall.com \
--cc=kernelnewbies@kernelnewbies.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=s.mesoraca16@gmail.com \
--cc=tobin@apporbit.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.