Re: [PATCH v2 08/11] PCI/IDE: Add IDE establishment helpers

[Aneesh Kumar K.V <aneesh.kumar@kernel.org>]

Dan Williams <dan.j.williams@intel.com> writes:

> Aneesh Kumar K.V wrote:
>> Dan Williams <dan.j.williams@intel.com> writes:
>> 
>> > There are two components to establishing an encrypted link, provisioning
>> > the stream in Partner Port config-space, and programming the keys into
>> > the link layer via IDE_KM (IDE Key Management). This new library,
>> > drivers/pci/ide.c, enables the former. IDE_KM, via a TSM low-level
>> > driver, is saved for later.
>> >
>> ....
>> 
>> > +/**
>> > + * pci_ide_stream_setup() - program settings to Selective IDE Stream registers
>> > + * @pdev: PCIe device object for either a Root Port or Endpoint Partner Port
>> > + * @ide: registered IDE settings descriptor
>> > + *
>> > + * When @pdev is a PCI_EXP_TYPE_ENDPOINT then the PCI_IDE_EP partner
>> > + * settings are written to @pdev's Selective IDE Stream register block,
>> > + * and when @pdev is a PCI_EXP_TYPE_ROOT_PORT, the PCI_IDE_RP settings
>> > + * are selected.
>> > + */
>> > +void pci_ide_stream_setup(struct pci_dev *pdev, struct pci_ide *ide)
>> > +{
>> > +	struct pci_ide_partner *settings = to_settings(pdev, ide);
>> > +	int pos;
>> > +	u32 val;
>> > +
>> > +	if (!settings)
>> > +		return;
>> > +
>> > +	pos = sel_ide_offset(pdev->nr_link_ide, settings->stream_index,
>> > +			     pdev->nr_ide_mem);
>> >
>> 
>> This and the similar offset caclulation below needs the EXT_CAP_ID_IDE offset 
>
> *facepalm*
>
> So it seems no one is trying to build on top of this framework yet.
>

You can find my POC work with this framework at
https://gitlab.arm.com/linux-arm/linux-cca/-/tree/cca-1.1/da/proto/rmm-1.1-alp12/v1
. I'm still reworking the patches, so I haven't posted them to the
mailing list yet.

-aneesh