From: Keith Packard <keithp@keithp.com>
To: Jesse Barnes <jbarnes@virtuousgeek.org>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: apply phase pointer override on SNB+ too
Date: Fri, 29 Jul 2011 11:47:55 -0700 [thread overview]
Message-ID: <yuntya4hqjo.fsf@aiko.keithp.com> (raw)
In-Reply-To: <1311961811-1813-1-git-send-email-jbarnes@virtuousgeek.org>
[-- Attachment #1.1: Type: text/plain, Size: 677 bytes --]
On Fri, 29 Jul 2011 10:50:11 -0700, Jesse Barnes <jbarnes@virtuousgeek.org> wrote:
> + flags |= FDI_PHASE_SYNC_OVR(pipe);
> + I915_WRITE(SOUTH_CHICKEN1, flags); /* once to unlock... */
> + flags |= FDI_PHASE_SYNC_EN(pipe);
> + I915_WRITE(SOUTH_CHICKEN1, flags); /* then again to enable */
> + POSTING_READ(SOUTH_CHICKEN1);
> +}
ooh, this even makes the sequence of two writes sound sensible.
Reviewed-by: Keith Packard <keithp@keithp.com>
You didn't happen to check the register values after doing this, did
you? Just to verify that all of the crazy math works, given that we
can't actually test whether this fixes anything.
--
keith.packard@intel.com
[-- Attachment #1.2: Type: application/pgp-signature, Size: 189 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2011-07-29 18:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-29 17:50 [PATCH] drm/i915: apply phase pointer override on SNB+ too Jesse Barnes
2011-07-29 18:47 ` Keith Packard [this message]
2011-07-29 19:43 ` Jesse Barnes
-- strict thread matches above, loose matches on Subject: below --
2011-07-29 19:42 Jesse Barnes
2011-07-29 21:22 ` Keith Packard
2011-07-29 21:55 ` Jesse Barnes
2011-07-29 0:07 Jesse Barnes
2011-07-29 17:28 ` Keith Packard
2011-07-29 0:06 Jesse Barnes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yuntya4hqjo.fsf@aiko.keithp.com \
--to=keithp@keithp.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jbarnes@virtuousgeek.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.