Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: <mariook@wp.pl>
To: Takashi Iwai <tiwai@suse.de>
Cc: alsa-devel@lists.sourceforge.net
Subject: Re: [PATCH] Asus A6RP and ALC861 headphones	problem	solved
Date: Fri, 20 Oct 2006 00:10:46 +0200	[thread overview]
Message-ID: <013c01c6f3cb$6dbde530$83030a54@MIREK> (raw)
In-Reply-To: s5hejt66aaj.wl%tiwai@suse.de


----- Original Message ----- 
From: "Takashi Iwai" <tiwai@suse.de>
To: <mariook@wp.pl>
Cc: <alsa-devel@lists.sourceforge.net>
Sent: Tuesday, October 17, 2006 8:56 PM
Subject: Re: [Alsa-devel] [PATCH] Asus A6RP and ALC861 headphones problem 
solved


> At Wed, 11 Oct 2006 18:45:52 +0200,
> I wrote:
>>
>> At Wed, 11 Oct 2006 18:36:02 +0200,
>> <mariook@wp.pl> wrote:
>> >
>> > ----- Original Message ----- 
>> > From: "Takashi Iwai" <tiwai@suse.de>
>> > To: <mariook@wp.pl>
>> > Cc: <alsa-devel@lists.sourceforge.net>
>> > Sent: Monday, October 09, 2006 3:31 PM
>> > Subject: Re: [Alsa-devel] [PATCH] Asus A6RP and ALC861 headphones 
>> > problem
>> > solved
>> >
>> > > At Sun, 8 Oct 2006 22:10:02 +0200,
>> > > <mariook@wp.pl> wrote:
>> > >>
>> > >> Hi!
>> > >>
>> > >> I finally made it, now can use headphones with my laptop :)
>> > >>
>> > >> My last thread (started on 23 Sep 20:08) about my problem is quite 
>> > >> long,
>> > >> so
>> > >> I decided to make a new one with result of my work - patched
>> > >> patch_realtek.c
>> > >> file.
>> > >>
>> > >> The patch I posted least time was good. The only thing that had to 
>> > >> be
>> > >> changed is to remove this line:
>> > >> .need_dac_fix = 1,
>> > >> from alc861_presets. With this line of code the patch doesn't want 
>> > >> to
>> > >> work.
>> > >
>> > > This implies that the headphone jack is connected to another DAC, 
>> > > most
>> > > likely the side one (0x04).  The right fix would to add .hp_nid = 
>> > > 0x04
>> > > in the preset table.  If 0x04 doesn't work, try 0x05 or 0x06 instead.
>> >
>> > .hp_nid = 0x06 worked (as I understood it's surround nid  - I wrote 
>> > earlier
>> > that in my case hp jack is surr-out (0x09))
>> >
>> > >> There is only one thing that I'm not sure...
>> > >> When channel mode is changed to 6ch the sound is in built-in 
>> > >> speakers,
>> > >> line-in jack and mic jack, but not in hp jack (of course when i plug
>> > >> something to hp jack the sound in built-in speakers disappears). Is 
>> > >> that
>> > >> correct?
>> >
>> > Even with fix described above this is still a problem - when channel 
>> > mode is
>> > set to 6ch the sound in hp jack is not present (the surround output 
>> > goes to
>> > line-in jack, there is also clfe output in mic jack and no output is in 
>> > hp
>> > jack).
>>
>> The stream is set up to hp_nid (0x06) too, regardless of the
>> channel mode.  You can confirm this by compiling with
>> --with-debug=detect option that will show more debug messages.
>> So, it shouldn't be the problem of hp_nid but others.
>>
>> If the no sound comes out, it means either pin is reset to input, or
>> a volume is muted in the route to DAC 0x06 -> hp-jack.  Check
>> /proc/asound/card0/codec#* after ch6 mode.  You can comapre the status
>> with ch6 mode, too, by simply diffing codec#* dumps in the different
>> states.
>
> I still wonder whether the HP output works on 6-channel mode if you
> remove .need_dac_fix = 1 in the preset...

As far as I remember it didn't work...

>> > >> Because each time I make a patch file it doesn't want to work (I 
>> > >> make it
>> > >> with this command: diff -Nuar old.file new.file), I'm sending in
>> > >> attachment
>> > >> compressed patch_realtek.c file (I patched final version 1.0.13 of
>> > >> patch_realtek.c). The only important changes are those connected 
>> > >> with
>> > >> asus-a6rp model, please ignore changes made in parts of code 
>> > >> connected
>> > >> with
>> > >> other models.
>> > >
>> > > Oh no, please send a patch instead.  Otherwise we cannot review and
>> > > check your changes.
>> > >
>> > > What do you mean "it doesn't want to work"?  If you changed a single
>> > > file, you can just create a diff for that file, simply by
>> > > diff -u orig-alsa-kernel/pci/hda/patch_realtek.c \
>> > > new-alsa-kernel/pci/hda/patch_realtek.c
>> >
>> > Ok, patch is in the attachment :)
>>
>> Thanks, but an uncompressed file would be more appreciated :)
>
> I checked the patch now and it looks good.
>
> Could you give a proper summary, changelog and signed-off-by line for
> committing to the upstream?  The remaining small issues can be fixed
> later, too.

Sorry but I don't understand, what changelog? Everything I have changed is 
in patch file.
The problem was with 3 things:
1) the hp jack is 0x09 not 0x0f (0x0f has to be set to vref)
2) hp_nid was wrong, it has to be set to 0x06
3) in 6ch mode surround output (hp jack output) 'jumps' to line-in jack, 
leaving no output in hp jack
What else should I write?

> Thanks,
>
> Takashi
>

Thanks,
Mariusz 


-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642

  reply	other threads:[~2006-10-19 22:10 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-10-08 20:10 [PATCH] Asus A6RP and ALC861 headphones problem solved mariook
2006-10-09 13:31 ` Takashi Iwai
2006-10-11 16:36   ` mariook
2006-10-11 16:45     ` Takashi Iwai
2006-10-17 18:56       ` Takashi Iwai
2006-10-19 22:10         ` mariook [this message]
2006-10-19 23:39           ` Tobin Davis
2006-10-20 13:33             ` Takashi Iwai
2006-10-20 20:21               ` mariook
2006-10-23 12:11                 ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='013c01c6f3cb$6dbde530$83030a54@MIREK' \
    --to=mariook@wp.pl \
    --cc=alsa-devel@lists.sourceforge.net \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox