From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
Mark Brown <broonie@kernel.org>
Cc: Linux-ALSA <alsa-devel@alsa-project.org>
Subject: Re: [alsa-devel] [PATCH 6/6] ASoC: soc-core: add snd_soc_stream_stop()
Date: Mon, 16 Dec 2019 21:22:28 -0600 [thread overview]
Message-ID: <01e4157a-d4b7-8bb2-d3bf-957d47e3e5f9@linux.intel.com> (raw)
In-Reply-To: <87o8w7hhds.wl-kuninori.morimoto.gx@renesas.com>
Hi Morimoto-san,
> +void snd_soc_stream_stop(struct snd_soc_pcm_runtime *rtd, int stream);
> +void snd_soc_stream_stop(struct snd_soc_pcm_runtime *rtd, int stream)
> +{
> + if (stream == SNDRV_PCM_STREAM_PLAYBACK) {
> + if (snd_soc_runtime_ignore_pmdown_time(rtd)) {
> + /* powered down playback stream now */
> + snd_soc_dapm_stream_event(rtd,
> + SNDRV_PCM_STREAM_PLAYBACK,
> + SND_SOC_DAPM_STREAM_STOP);
> + } else {
> + /* start delayed pop wq here for playback streams */
> + rtd->pop_wait = 1;
> + queue_delayed_work(system_power_efficient_wq,
> + &rtd->delayed_work,
> + msecs_to_jiffies(rtd->pmdown_time));
> + }
> + } else {
> + /* capture streams can be powered down now */
> + snd_soc_dapm_stream_event(rtd, SNDRV_PCM_STREAM_CAPTURE,
> + SND_SOC_DAPM_STREAM_STOP);
> + }
> +}
> +EXPORT_SYMBOL_GPL(snd_soc_stream_stop);
I am not a big fan of naming conventions for the new helper. We don't
have any other snd_soc_stream function, but we have a concept of stream
for SoundWire. we also have snd_soc_dapm_stream_ functions..
snd_soc_dapm_stream_stop() maybe?
thanks
-Pierre
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next prev parent reply other threads:[~2019-12-17 3:23 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-17 1:25 [alsa-devel] [PATCH 0/6] ASoC: soc-core cleanup step8 Kuninori Morimoto
2019-12-17 1:25 ` [alsa-devel] [PATCH 1/6] ASoC: soc-core: remove snd_soc_rtdcom_list Kuninori Morimoto
2019-12-17 1:25 ` [alsa-devel] [PATCH 2/6] ASoC: soc-core: care .ignore_suspend for Component suspend Kuninori Morimoto
2019-12-17 1:26 ` [alsa-devel] [PATCH 3/6] ASoC: soc-core: remove duplicate pinctrl operation when suspend Kuninori Morimoto
2019-12-17 1:26 ` [alsa-devel] [PATCH 4/6] ASoC: soc-core: do pinctrl_pm_select_xxx() as component Kuninori Morimoto
2019-12-17 1:26 ` [alsa-devel] [PATCH 5/6] ASoC: soc-core: add snd_soc_close_delayed_work() Kuninori Morimoto
2019-12-17 1:26 ` [alsa-devel] [PATCH 6/6] ASoC: soc-core: add snd_soc_stream_stop() Kuninori Morimoto
2019-12-17 3:22 ` Pierre-Louis Bossart [this message]
2019-12-17 3:54 ` Kuninori Morimoto
2019-12-17 4:41 ` Kuninori Morimoto
2019-12-17 12:13 ` Mark Brown
2019-12-17 13:56 ` Pierre-Louis Bossart
2019-12-18 1:51 ` Kuninori Morimoto
2019-12-18 11:50 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=01e4157a-d4b7-8bb2-d3bf-957d47e3e5f9@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=kuninori.morimoto.gx@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox