From: Mark Brown <broonie@kernel.org>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Cc: Linux-ALSA <alsa-devel@alsa-project.org>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Subject: Re: [alsa-devel] [PATCH 6/6] ASoC: soc-core: add snd_soc_stream_stop()
Date: Wed, 18 Dec 2019 11:50:32 +0000 [thread overview]
Message-ID: <20191218115032.GC3219@sirena.org.uk> (raw)
In-Reply-To: <124fd50c-db99-7a4a-9e35-ad69b5e16abc@linux.intel.com>
[-- Attachment #1.1: Type: text/plain, Size: 1050 bytes --]
On Tue, Dec 17, 2019 at 07:56:28AM -0600, Pierre-Louis Bossart wrote:
> On 12/17/19 6:13 AM, Mark Brown wrote:
> > On Tue, Dec 17, 2019 at 01:41:09PM +0900, Kuninori Morimoto wrote:
> > > Can we use snd_soc_dapm_stream_stop() for these, too ?
> > That does seem like an oversight...
> What would the rationale for deferring a FE shutdown though?
> IIRC in the Intel machine drivers we only use .pm_ignore_downtime to
> backends to keep some clocks on, and even that is questionable (the clock
> dependencies should be properly modeled instead of hidden with an obscure
> dailink setting). When I asked why exactly this flag was set in most cases
> the reason why 'because others did so in the past'...
It's there as a hack to keep clocks live or to avoid pops and clicks as
the datastream goes to zero during shutdown if the CODEC doesn't support
mute or otherwise handle the input going away cleanly (which is just a
more general case of keeping the clocks live usually). You'd do it for
front ends as well to make sure things are consistent.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 161 bytes --]
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
prev parent reply other threads:[~2019-12-18 11:51 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-17 1:25 [alsa-devel] [PATCH 0/6] ASoC: soc-core cleanup step8 Kuninori Morimoto
2019-12-17 1:25 ` [alsa-devel] [PATCH 1/6] ASoC: soc-core: remove snd_soc_rtdcom_list Kuninori Morimoto
2019-12-17 1:25 ` [alsa-devel] [PATCH 2/6] ASoC: soc-core: care .ignore_suspend for Component suspend Kuninori Morimoto
2019-12-17 1:26 ` [alsa-devel] [PATCH 3/6] ASoC: soc-core: remove duplicate pinctrl operation when suspend Kuninori Morimoto
2019-12-17 1:26 ` [alsa-devel] [PATCH 4/6] ASoC: soc-core: do pinctrl_pm_select_xxx() as component Kuninori Morimoto
2019-12-17 1:26 ` [alsa-devel] [PATCH 5/6] ASoC: soc-core: add snd_soc_close_delayed_work() Kuninori Morimoto
2019-12-17 1:26 ` [alsa-devel] [PATCH 6/6] ASoC: soc-core: add snd_soc_stream_stop() Kuninori Morimoto
2019-12-17 3:22 ` Pierre-Louis Bossart
2019-12-17 3:54 ` Kuninori Morimoto
2019-12-17 4:41 ` Kuninori Morimoto
2019-12-17 12:13 ` Mark Brown
2019-12-17 13:56 ` Pierre-Louis Bossart
2019-12-18 1:51 ` Kuninori Morimoto
2019-12-18 11:50 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191218115032.GC3219@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=pierre-louis.bossart@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox