From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Mark Brown <broonie@kernel.org>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: Linux-ALSA <alsa-devel@alsa-project.org>
Subject: Re: [alsa-devel] [PATCH 6/6] ASoC: soc-core: add snd_soc_stream_stop()
Date: Tue, 17 Dec 2019 07:56:28 -0600 [thread overview]
Message-ID: <124fd50c-db99-7a4a-9e35-ad69b5e16abc@linux.intel.com> (raw)
In-Reply-To: <20191217121308.GC4755@sirena.org.uk>
On 12/17/19 6:13 AM, Mark Brown wrote:
> On Tue, Dec 17, 2019 at 01:41:09PM +0900, Kuninori Morimoto wrote:
>
>> I noticed that soc_compr_free_fe(), dpcm_fe_dai_shutdown() are directly
>> calling SND_SOC_DAPM_STREAM_STOP without caring pmdown time / delayed work.
>> Can we use snd_soc_dapm_stream_stop() for these, too ?
>
> That does seem like an oversight...
What would the rationale for deferring a FE shutdown though?
IIRC in the Intel machine drivers we only use .pm_ignore_downtime to
backends to keep some clocks on, and even that is questionable (the
clock dependencies should be properly modeled instead of hidden with an
obscure dailink setting). When I asked why exactly this flag was set in
most cases the reason why 'because others did so in the past'...
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next prev parent reply other threads:[~2019-12-17 15:30 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-17 1:25 [alsa-devel] [PATCH 0/6] ASoC: soc-core cleanup step8 Kuninori Morimoto
2019-12-17 1:25 ` [alsa-devel] [PATCH 1/6] ASoC: soc-core: remove snd_soc_rtdcom_list Kuninori Morimoto
2019-12-17 1:25 ` [alsa-devel] [PATCH 2/6] ASoC: soc-core: care .ignore_suspend for Component suspend Kuninori Morimoto
2019-12-17 1:26 ` [alsa-devel] [PATCH 3/6] ASoC: soc-core: remove duplicate pinctrl operation when suspend Kuninori Morimoto
2019-12-17 1:26 ` [alsa-devel] [PATCH 4/6] ASoC: soc-core: do pinctrl_pm_select_xxx() as component Kuninori Morimoto
2019-12-17 1:26 ` [alsa-devel] [PATCH 5/6] ASoC: soc-core: add snd_soc_close_delayed_work() Kuninori Morimoto
2019-12-17 1:26 ` [alsa-devel] [PATCH 6/6] ASoC: soc-core: add snd_soc_stream_stop() Kuninori Morimoto
2019-12-17 3:22 ` Pierre-Louis Bossart
2019-12-17 3:54 ` Kuninori Morimoto
2019-12-17 4:41 ` Kuninori Morimoto
2019-12-17 12:13 ` Mark Brown
2019-12-17 13:56 ` Pierre-Louis Bossart [this message]
2019-12-18 1:51 ` Kuninori Morimoto
2019-12-18 11:50 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=124fd50c-db99-7a4a-9e35-ad69b5e16abc@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=kuninori.morimoto.gx@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox