Re: 2.6.10-rc2 on VAIO laptop and PowerMac 8500/G3

Re: 2.6.10-rc2 on VAIO laptop and PowerMac 8500/G3

[Lee Revell]

Please cc: alsa-devel on ALSA issues (we now allow posts from non
subscribers! :-P).

On Sat, 2004-11-20 at 19:51 +0100, Pavel Machek wrote:
> Hi!
> 
> > The software suspend issue was long and tedious to narrow down.  Yep, as
> > you suspected, it appears to be specific a driver (or group thereof).  It
> > appears to happen when the sound subsystem is included.  Attached below 
> > is the .config and a 'diff' from the losing one to one which works.
> 
> Okay, this is for the alsa team then. Somewhere between 2.6.10-rc1 and
> 2.6.10-rc2, ALSA started breaking swsusp :-(.
> 								Pavel
> 
-- 
Lee Revell <rlrevell@joe-job.com>

Re: 2.6.10-rc2 on VAIO laptop and PowerMac 8500/G3

[Takashi Iwai]

At Sat, 20 Nov 2004 14:11:42 -0500,
Lee Revell wrote:
> 
> Please cc: alsa-devel on ALSA issues (we now allow posts from non
> subscribers! :-P).

It's a known problem and already fixed on ALSA CVS.
Sice 2.6.10-rc2, pci_save_state() is no longer called as default when
suspend callback is set.  The patch is below.


Takashi

--- linux/sound/core/init.c	8 Nov 2004 11:37:08 -0000	1.48
+++ linux/sound/core/init.c	12 Nov 2004 13:56:32 -0000
@@ -782,12 +782,15 @@
 int snd_card_pci_suspend(struct pci_dev *dev, u32 state)
 {
 	snd_card_t *card = pci_get_drvdata(dev);
+	int err;
 	if (! card || ! card->pm_suspend)
 		return 0;
 	if (card->power_state == SNDRV_CTL_POWER_D3hot)
 		return 0;
 	/* FIXME: correct state value? */
-	return card->pm_suspend(card, 0);
+	err = card->pm_suspend(card, 0);
+	pci_save_state(dev);
+	return err;
 }
 
 int snd_card_pci_resume(struct pci_dev *dev)


-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now. 
http://productguide.itmanagersjournal.com/