Re: [PATCH] hda empty modelname comparison

[Tobin Davis <tdavis@dsl-only.net>]

[-- Attachment #1.1: Type: text/plain, Size: 630 bytes --]

On Tue, 2007-03-06 at 15:59 +0100, Joachim Deguara wrote:

> This patch prevents a comparison between a possibly empty modelname
> string in the hda code.
> 
> -Joachim


Unfortunately, the way the original patch was written, the only options
are generic or segfault.  Your patch just removes the segfault, sending
all cards to the generic parser.

I've tested a slightly different approach, based on your empty test,
just reverse logic.  Test it to confirm that it works.  It works on my
system with a Conexant reference board and a Sigmatel STAC9227 (both on
the same system).



Signed off by Tobin Davis <tdavis@dsl-only.net>

[-- Attachment #1.2: Type: text/html, Size: 1119 bytes --]

[-- Attachment #2: generic-fix.patch --]
[-- Type: text/x-patch, Size: 490 bytes --]

diff -r bf193701a812 pci/hda/hda_codec.c
--- a/pci/hda/hda_codec.c	Mon Feb 26 16:07:42 2007 +0100
+++ b/pci/hda/hda_codec.c	Wed Mar 07 12:02:37 2007 -0800
@@ -573,7 +573,7 @@ int snd_hda_codec_new(struct hda_bus *bu
 							 0);
 	}
 
-	if (strcmp(codec->bus->modelname, "generic"))
+	if (!(codec->bus->modelname && strcmp(codec->bus->modelname, "generic")))
 		codec->preset = find_codec_preset(codec);
 	if (! *bus->card->mixername)
 		snd_hda_get_codec_name(codec, bus->card->mixername,

[-- Attachment #3: Type: text/plain, Size: 345 bytes --]

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV

[-- Attachment #4: Type: text/plain, Size: 161 bytes --]

_______________________________________________
Alsa-devel mailing list
Alsa-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/alsa-devel