From: Tobin Davis <tdavis@dsl-only.net>
To: Takashi Iwai <tiwai@suse.de>
Cc: Joachim Deguara <joachim.deguara@amd.com>,
alsa-devel@lists.sourceforge.net
Subject: Re: [PATCH] hda empty modelname comparison
Date: Wed, 07 Mar 2007 14:51:38 -0800 [thread overview]
Message-ID: <1173307898.4531.7.camel@razman.gruemaster.com> (raw)
In-Reply-To: <s5hodn4agyz.wl%tiwai@suse.de>
[-- Attachment #1.1: Type: text/plain, Size: 426 bytes --]
On Wed, 2007-03-07 at 22:20 +0100, Takashi Iwai wrote:
> + if (codec->bus->modelname && !strcmp(codec->bus->modelname,
> "generic"))
> + return NULL; /* use the generic parser */
>
Should be:
+ if (codec->bus->modelname && strcmp(codec->bus->modelname,
"generic"))
+ return NULL; /* use the generic parser */
You've got the logic reversed.
--
Tobin Davis <tdavis@dsl-only.net>
[-- Attachment #1.2: Type: text/html, Size: 1250 bytes --]
[-- Attachment #2: Type: text/plain, Size: 345 bytes --]
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
[-- Attachment #3: Type: text/plain, Size: 161 bytes --]
_______________________________________________
Alsa-devel mailing list
Alsa-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/alsa-devel
next prev parent reply other threads:[~2007-03-07 22:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-06 14:59 [PATCH] hda empty modelname comparison Joachim Deguara
2007-03-07 20:04 ` Tobin Davis
2007-03-07 21:20 ` Takashi Iwai
2007-03-07 22:51 ` Tobin Davis [this message]
2007-03-07 22:58 ` Tobin Davis
2007-03-08 14:32 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1173307898.4531.7.camel@razman.gruemaster.com \
--to=tdavis@dsl-only.net \
--cc=alsa-devel@lists.sourceforge.net \
--cc=joachim.deguara@amd.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox