From: "Joachim Deguara" <joachim.deguara@amd.com>
To: alsa-devel@lists.sourceforge.net
Subject: [PATCH] hda empty modelname comparison
Date: Tue, 06 Mar 2007 15:59:10 +0100 [thread overview]
Message-ID: <45ED81BE.4080606@amd.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 102 bytes --]
This patch prevents a comparison between a possibly empty modelname
string in the hda code.
-Joachim
[-- Attachment #2: hda_empty_modelname_comparison.patch --]
[-- Type: text/x-patch, Size: 656 bytes --]
Only in alsa-kernel/include: version.h
diff -rup /mnt/alsa/alsa-kernel/pci/hda/hda_codec.c alsa-kernel/pci/hda/hda_codec.c
--- /mnt/alsa/alsa-kernel/pci/hda/hda_codec.c 2007-03-01 14:50:24.000000000 +0100
+++ alsa-kernel/pci/hda/hda_codec.c 2007-03-06 15:37:03.000000000 +0100
@@ -573,7 +573,7 @@ int snd_hda_codec_new(struct hda_bus *bu
0);
}
- if (strcmp(codec->bus->modelname, "generic"))
+ if ( codec->bus->modelname && strcmp(codec->bus->modelname, "generic"))
codec->preset = find_codec_preset(codec);
if (! *bus->card->mixername)
snd_hda_get_codec_name(codec, bus->card->mixername,
Only in alsa-kernel/pci/hda: .hda_codec.c.swp
[-- Attachment #3: Type: text/plain, Size: 345 bytes --]
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
[-- Attachment #4: Type: text/plain, Size: 161 bytes --]
_______________________________________________
Alsa-devel mailing list
Alsa-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/alsa-devel
next reply other threads:[~2007-03-06 14:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-06 14:59 Joachim Deguara [this message]
2007-03-07 20:04 ` [PATCH] hda empty modelname comparison Tobin Davis
2007-03-07 21:20 ` Takashi Iwai
2007-03-07 22:51 ` Tobin Davis
2007-03-07 22:58 ` Tobin Davis
2007-03-08 14:32 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45ED81BE.4080606@amd.com \
--to=joachim.deguara@amd.com \
--cc=alsa-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox