From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: alsa-devel@alsa-project.org,
Mark Brown <broonie@opensource.wolfsonmicro.com>
Subject: [PATCH 10/10] ASoC: Improve error reporting for AC97 reset failures
Date: Fri, 21 Nov 2008 14:48:33 +0000 [thread overview]
Message-ID: <1227278913-25313-10-git-send-email-broonie@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1227278913-25313-9-git-send-email-broonie@opensource.wolfsonmicro.com>
Print something a bit more verbose to help make errors a little more
obvious.
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
---
sound/soc/codecs/ad1980.c | 2 +-
sound/soc/codecs/wm9712.c | 2 +-
sound/soc/codecs/wm9713.c | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/sound/soc/codecs/ad1980.c b/sound/soc/codecs/ad1980.c
index 410fed9..1a3ea05 100644
--- a/sound/soc/codecs/ad1980.c
+++ b/sound/soc/codecs/ad1980.c
@@ -238,7 +238,7 @@ static int ad1980_soc_probe(struct platform_device *pdev)
ret = ad1980_reset(codec, 0);
if (ret < 0) {
- printk(KERN_ERR "AC97 link error\n");
+ printk(KERN_ERR "Failed to reset AD1980: AC97 link error\n");
goto reset_err;
}
diff --git a/sound/soc/codecs/wm9712.c b/sound/soc/codecs/wm9712.c
index 81c38e7..6e3e0f3 100644
--- a/sound/soc/codecs/wm9712.c
+++ b/sound/soc/codecs/wm9712.c
@@ -690,7 +690,7 @@ static int wm9712_soc_probe(struct platform_device *pdev)
ret = wm9712_reset(codec, 0);
if (ret < 0) {
- printk(KERN_ERR "AC97 link error\n");
+ printk(KERN_ERR "Failed to reset WM9712: AC97 link error\n");
goto reset_err;
}
diff --git a/sound/soc/codecs/wm9713.c b/sound/soc/codecs/wm9713.c
index a0cc5ac..7be811a 100644
--- a/sound/soc/codecs/wm9713.c
+++ b/sound/soc/codecs/wm9713.c
@@ -1243,7 +1243,7 @@ static int wm9713_soc_probe(struct platform_device *pdev)
wm9713_reset(codec, 0);
ret = wm9713_reset(codec, 1);
if (ret < 0) {
- printk(KERN_ERR "AC97 link error\n");
+ printk(KERN_ERR "Failed to reset WM9713: AC97 link error\n");
goto reset_err;
}
--
1.5.6.5
next prev parent reply other threads:[~2008-11-21 14:48 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-21 14:47 [PATCH 0/10] ASoC updates Mark Brown
2008-11-21 14:48 ` [PATCH 01/10] ASoC: Rename snd_soc_card to snd_soc_machine Mark Brown
2008-11-21 14:48 ` [PATCH 02/10] ASoC: Add abbreviation to maintainers for searchability Mark Brown
2008-11-21 14:48 ` [PATCH 03/10] ASoC: ssm2602: Fix priv substreams refs Mark Brown
2008-11-21 14:48 ` [PATCH 04/10] ASoC: ssm2602: Update supported stream formats Mark Brown
2008-11-21 14:48 ` [PATCH 05/10] ASoC: Move DAI structure definitions into new soc-dai.h Mark Brown
2008-11-21 14:48 ` [PATCH 06/10] ASoC: Merge snd_soc_ops into snd_soc_dai_ops Mark Brown
2008-11-21 14:48 ` [PATCH 07/10] ASoC: Add Marvell Zylonite machine support Mark Brown
2008-11-21 14:48 ` [PATCH 08/10] ASoC: OMAP: Fix preprocessor filled DAI name in McBSP DAI Mark Brown
2008-11-21 14:48 ` [PATCH 09/10] ASoC: Staticise pxa2xx_pcm_ops Mark Brown
2008-11-21 14:48 ` Mark Brown [this message]
2008-11-21 14:55 ` [PATCH 01/10] ASoC: Rename snd_soc_card to snd_soc_machine Takashi Iwai
2008-11-21 15:02 ` Mark Brown
2008-11-21 15:04 ` Takashi Iwai
2008-11-21 15:05 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1227278913-25313-10-git-send-email-broonie@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox