Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
* Bug#596478: [PATCH] ALSA: emux: Add trivial compat ioctl handler
@ 2010-09-12  1:41 Ben Hutchings
  2010-09-14 14:20 ` Takashi Iwai
  0 siblings, 1 reply; 2+ messages in thread
From: Ben Hutchings @ 2010-09-12  1:41 UTC (permalink / raw)
  To: Jaroslav Kysela, Takashi Iwai; +Cc: alsa-devel, Carmen Cru, 596478

Reported-by: Carmen Cru <carmen.cru@belgacom.net>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
---
This is compile-tested only.

Ben.

 sound/synth/emux/emux_hwdep.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/sound/synth/emux/emux_hwdep.c b/sound/synth/emux/emux_hwdep.c
index ff0b2a8..5ae1eae 100644
--- a/sound/synth/emux/emux_hwdep.c
+++ b/sound/synth/emux/emux_hwdep.c
@@ -128,6 +128,9 @@ snd_emux_init_hwdep(struct snd_emux *emu)
 	strcpy(hw->name, SNDRV_EMUX_HWDEP_NAME);
 	hw->iface = SNDRV_HWDEP_IFACE_EMUX_WAVETABLE;
 	hw->ops.ioctl = snd_emux_hwdep_ioctl;
+	/* The ioctl parameter types are compatible between 32- and
+	 * 64-bit architectures, so use the same function. */
+	hw->ops.ioctl_compat = snd_emux_hwdep_ioctl;
 	hw->exclusive = 1;
 	hw->private_data = emu;
 	if ((err = snd_card_register(emu->card)) < 0)
-- 
1.7.1

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] ALSA: emux: Add trivial compat ioctl handler
  2010-09-12  1:41 Bug#596478: [PATCH] ALSA: emux: Add trivial compat ioctl handler Ben Hutchings
@ 2010-09-14 14:20 ` Takashi Iwai
  0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2010-09-14 14:20 UTC (permalink / raw)
  To: Ben Hutchings; +Cc: 596478, alsa-devel, Carmen Cru

At Sun, 12 Sep 2010 02:41:47 +0100,
Ben Hutchings wrote:
> 
> Reported-by: Carmen Cru <carmen.cru@belgacom.net>
> Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
> ---
> This is compile-tested only.

Thanks, applied now.


Takashi

> 
> Ben.
> 
>  sound/synth/emux/emux_hwdep.c |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
> 
> diff --git a/sound/synth/emux/emux_hwdep.c b/sound/synth/emux/emux_hwdep.c
> index ff0b2a8..5ae1eae 100644
> --- a/sound/synth/emux/emux_hwdep.c
> +++ b/sound/synth/emux/emux_hwdep.c
> @@ -128,6 +128,9 @@ snd_emux_init_hwdep(struct snd_emux *emu)
>  	strcpy(hw->name, SNDRV_EMUX_HWDEP_NAME);
>  	hw->iface = SNDRV_HWDEP_IFACE_EMUX_WAVETABLE;
>  	hw->ops.ioctl = snd_emux_hwdep_ioctl;
> +	/* The ioctl parameter types are compatible between 32- and
> +	 * 64-bit architectures, so use the same function. */
> +	hw->ops.ioctl_compat = snd_emux_hwdep_ioctl;
>  	hw->exclusive = 1;
>  	hw->private_data = emu;
>  	if ((err = snd_card_register(emu->card)) < 0)
> -- 
> 1.7.1
> 
> 

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2010-09-14 14:20 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-09-12  1:41 Bug#596478: [PATCH] ALSA: emux: Add trivial compat ioctl handler Ben Hutchings
2010-09-14 14:20 ` Takashi Iwai

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox