From: Liam Girdwood <lrg@slimlogic.co.uk>
To: Timur Tabi <timur@freescale.com>
Cc: dp@opensource.wolfsonmicro.com, alsa-devel@alsa-project.org,
broonie@opensource.wolfsonmicro.com
Subject: Re: [PATCH] [v3] ASoC: cs4270: use the built-in register cache support
Date: Mon, 10 Jan 2011 21:59:25 +0000 [thread overview]
Message-ID: <1294696765.3416.243.camel@odin> (raw)
In-Reply-To: <1294687713-16433-1-git-send-email-timur@freescale.com>
On Mon, 2011-01-10 at 13:28 -0600, Timur Tabi wrote:
> Update the CS4270 driver to use ASoC's internal codec register cache feature.
> This change allows ASoC to perform the low-level I2C operations necessary to
> read the register cache. Support is also added for initializing the register
> cache with an array of known power-on default values.
>
> The CS4270 driver was handling the register cache itself, but somwhere along
> the conversion to multi-compaonent, this feature broke.
>
> Signed-off-by: Timur Tabi <timur@freescale.com>
Acked-by: Liam Girdwood <lrg@slimlogic.co.uk>
> ---
>
> Mark, I don't have power-management support working on my hardware, so I can't
> test cs4270_soc_resume(), but I have a suspicion that the call to
> i2c_smbus_write_byte_data() should be replaced with codec->hw_write().
>
You may want to look at using snd_soc_cache_sync() to flush your cache
at resume().
Thanks
Liam
--
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk
next prev parent reply other threads:[~2011-01-10 22:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-10 19:28 [PATCH] [v3] ASoC: cs4270: use the built-in register cache support Timur Tabi
2011-01-10 19:28 ` [PATCH] ASoC: let snd_soc_update_bits() return an error code Timur Tabi
2011-01-10 19:29 ` Mark Brown
2011-01-10 19:35 ` Timur Tabi
2011-01-10 21:59 ` Liam Girdwood [this message]
2011-01-10 22:34 ` [PATCH] [v3] ASoC: cs4270: use the built-in register cache support Mark Brown
2011-01-10 22:37 ` Timur Tabi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1294696765.3416.243.camel@odin \
--to=lrg@slimlogic.co.uk \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=dp@opensource.wolfsonmicro.com \
--cc=timur@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox