From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Timur Tabi <timur@freescale.com>
Cc: dp@opensource.wolfsonmicro.com, alsa-devel@alsa-project.org,
lrg@slimlogic.co.uk
Subject: Re: [PATCH] ASoC: let snd_soc_update_bits() return an error code
Date: Mon, 10 Jan 2011 19:29:01 +0000 [thread overview]
Message-ID: <20110110192901.GA11684@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1294687713-16433-2-git-send-email-timur@freescale.com>
On Mon, Jan 10, 2011 at 01:28:33PM -0600, Timur Tabi wrote:
> + ret = old = snd_soc_read(codec, reg);
> + if (ret < 0)
> + return ret;
Please don't use multiple assignments in a single statement, it does
nothing for legibility.
next prev parent reply other threads:[~2011-01-10 19:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-10 19:28 [PATCH] [v3] ASoC: cs4270: use the built-in register cache support Timur Tabi
2011-01-10 19:28 ` [PATCH] ASoC: let snd_soc_update_bits() return an error code Timur Tabi
2011-01-10 19:29 ` Mark Brown [this message]
2011-01-10 19:35 ` Timur Tabi
2011-01-10 21:59 ` [PATCH] [v3] ASoC: cs4270: use the built-in register cache support Liam Girdwood
2011-01-10 22:34 ` Mark Brown
2011-01-10 22:37 ` Timur Tabi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110110192901.GA11684@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=dp@opensource.wolfsonmicro.com \
--cc=lrg@slimlogic.co.uk \
--cc=timur@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox