From: Timur Tabi <timur@freescale.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: dp@opensource.wolfsonmicro.com, alsa-devel@alsa-project.org,
lrg@slimlogic.co.uk
Subject: Re: [PATCH] [v3] ASoC: cs4270: use the built-in register cache support
Date: Mon, 10 Jan 2011 16:37:43 -0600 [thread overview]
Message-ID: <4D2B8A37.5070900@freescale.com> (raw)
In-Reply-To: <20110110223400.GE5886@opensource.wolfsonmicro.com>
Mark Brown wrote:
>> > Mark, I don't have power-management support working on my hardware, so I can't
>> > test cs4270_soc_resume(), but I have a suspicion that the call to
>> > i2c_smbus_write_byte_data() should be replaced with codec->hw_write().
> Like Liam said snd_soc_cache_sync() is probably what you're looking for
> here.
Unfortunately, since I can't test any power management stuff on the 8610, I
can't test any changes. I have to rely on the author of power management code
to do that.
--
Timur Tabi
Linux kernel developer at Freescale
prev parent reply other threads:[~2011-01-10 22:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-10 19:28 [PATCH] [v3] ASoC: cs4270: use the built-in register cache support Timur Tabi
2011-01-10 19:28 ` [PATCH] ASoC: let snd_soc_update_bits() return an error code Timur Tabi
2011-01-10 19:29 ` Mark Brown
2011-01-10 19:35 ` Timur Tabi
2011-01-10 21:59 ` [PATCH] [v3] ASoC: cs4270: use the built-in register cache support Liam Girdwood
2011-01-10 22:34 ` Mark Brown
2011-01-10 22:37 ` Timur Tabi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D2B8A37.5070900@freescale.com \
--to=timur@freescale.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=dp@opensource.wolfsonmicro.com \
--cc=lrg@slimlogic.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox