From: Liam Girdwood <lrg@ti.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
Stephen Warren <swarren@wwwdotorg.org>
Subject: Re: Confusing about Playback/Capture, CODEC/CODEC links, and snd_soc_dapm_link_dai_widgets()
Date: Fri, 01 Jun 2012 18:01:57 +0100 [thread overview]
Message-ID: <1338570117.5179.2.camel@odin> (raw)
In-Reply-To: <20120531233702.GA30717@opensource.wolfsonmicro.com>
On Fri, 2012-06-01 at 00:37 +0100, Mark Brown wrote:
> On Thu, May 31, 2012 at 04:49:26PM -0600, Stephen Warren wrote:
>
> This is all working just fine in mainline on littlemill.
>
> > > int snd_soc_dapm_dai_get_connected_widgets(struct snd_soc_dai *dai, int stream,
> > > struct snd_soc_dapm_widget_list **list)
> > ...
> > > if (stream == SNDRV_PCM_STREAM_PLAYBACK)
> > > paths = is_connected_output_ep(dai->playback_widget, list);
> > > else
> > > paths = is_connected_input_ep(dai->playback_widget, list);
>
> > I would have expected this to use capture_widget on the final line, but
> > I haven't thought about this in detail, just noticed the lack of
> > symmetry by very brief inspection.
>
> Yes, that looks buggy. Don't think there's any mainline users so nobody
> would notice.
Gah, it's a bug - I did have it fixed before the upstreaming but this
fix seems to have been lost.
Patch on it's way.
Liam
next prev parent reply other threads:[~2012-06-01 17:02 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-31 22:49 Confusing about Playback/Capture, CODEC/CODEC links, and snd_soc_dapm_link_dai_widgets() Stephen Warren
2012-05-31 23:37 ` Mark Brown
2012-06-01 17:01 ` Liam Girdwood [this message]
2012-06-04 13:02 ` Sebastien LEDUC
2012-06-04 16:57 ` Liam Girdwood
2012-06-01 21:41 ` Mark Brown
2012-06-01 22:31 ` Confusion " Stephen Warren
2012-06-05 20:24 ` Stephen Warren
2012-06-05 20:48 ` Mark Brown
2012-06-05 21:17 ` Stephen Warren
2012-06-05 21:34 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1338570117.5179.2.camel@odin \
--to=lrg@ti.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox