From: Liam Girdwood <lrg@ti.com>
To: Sebastien LEDUC <sebastien.leduc@stericsson.com>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
Stephen Warren <swarren@wwwdotorg.org>
Subject: Re: Confusing about Playback/Capture, CODEC/CODEC links, and snd_soc_dapm_link_dai_widgets()
Date: Mon, 04 Jun 2012 17:57:19 +0100 [thread overview]
Message-ID: <1338829039.15595.5.camel@odin> (raw)
In-Reply-To: <A3217089E06965468FCEC60ADC3A8F925C172270E5@EXDCVYMBSTM006.EQ1STM.local>
On Mon, 2012-06-04 at 15:02 +0200, Sebastien LEDUC wrote:
> Hi Liam
> There seem to be a similar mistake in the implementation of is_connected_output_ep / is_connected_input_ep:
>
> In function is_connected_output_ep:
> -----------------------------------------------
>
> list_for_each_entry(path, &widget->sinks, list_source) {
> ...
> err = dapm_list_add_widget(list, path->sink);
> ...
> }
>
> In function is_connected_input_ep:
> ---------------------------------------------
>
> list_for_each_entry(path, &widget->sources, list_sink) {
> ...
> err = dapm_list_add_widget(list, path->sink);
> }
>
>
> I would have expected to have for the latter:
> err = dapm_list_add_widget(list, path->source);
Your right, this patch also got somehow dropped from squashing prior to
upstream. I'll send the fix shortly.
Thanks
Liam
next prev parent reply other threads:[~2012-06-04 16:57 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-31 22:49 Confusing about Playback/Capture, CODEC/CODEC links, and snd_soc_dapm_link_dai_widgets() Stephen Warren
2012-05-31 23:37 ` Mark Brown
2012-06-01 17:01 ` Liam Girdwood
2012-06-04 13:02 ` Sebastien LEDUC
2012-06-04 16:57 ` Liam Girdwood [this message]
2012-06-01 21:41 ` Mark Brown
2012-06-01 22:31 ` Confusion " Stephen Warren
2012-06-05 20:24 ` Stephen Warren
2012-06-05 20:48 ` Mark Brown
2012-06-05 21:17 ` Stephen Warren
2012-06-05 21:34 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1338829039.15595.5.camel@odin \
--to=lrg@ti.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=sebastien.leduc@stericsson.com \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox