From: Joe Perches <joe@perches.com>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: Takashi Iwai <tiwai@suse.de>, alsa-devel@alsa-project.org
Subject: Re: [PATCH] ALSA: get rid of CONFIG_SND_VERBOSE_PRINTK
Date: Tue, 04 Jun 2013 14:19:45 -0700 [thread overview]
Message-ID: <1370380785.2385.69.camel@joe-AO722> (raw)
In-Reply-To: <Pine.LNX.4.44L0.1306041646240.1093-100000@iolanthe.rowland.org>
On Tue, 2013-06-04 at 16:54 -0400, Alan Stern wrote:
> I don't see how DEFAULT_DEBUG_LEVEL can be used to optimize away
> anything. The user can always change the value of the "debug" module
> parameter while the system is running. The only valid opportunity for
> optimization would be if CONFIG_SND_DEBUG was disabled; then all these
> messages would disappear.
Not really.
Think of CONFIG_SND_DEBUG as a level. (0, 1, 2)
or maybe think of it as CONFIG_SND_DEBUG_VERBOSITY.
There could still be ability to have CONFIG_SND_DEBUG
limit the compiled-in messages to those below the
#define value and still then have runtime control over
which ones are displayed.
> You didn't respond to the first point I raised. Since these messages
> are all meant for debugging, there's no point allowing them to have
> prefixes like KERN_ERR or KERN_INFO. They should always be printed at
> the KERN_DEBUG level. Or did you think this was so obviously true that
> it didn't require any comment?
Yes. My perspective is _all_ debugging messages should
be at KERN_DEBUG.
next prev parent reply other threads:[~2013-06-04 21:19 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-03 20:18 [PATCH] ALSA: get rid of CONFIG_SND_VERBOSE_PRINTK Alan Stern
2013-06-03 20:24 ` Joe Perches
2013-06-03 20:40 ` Alan Stern
2013-06-03 20:49 ` Joe Perches
2013-06-04 9:13 ` Takashi Iwai
2013-06-04 14:49 ` Alan Stern
2013-06-04 15:03 ` Takashi Iwai
2013-06-04 17:20 ` [PATCH 1/2] ALSA: convert "snd_printk(KERN_INFO" to "pr_info(" Alan Stern
2013-06-05 5:52 ` Takashi Iwai
2013-06-05 6:07 ` Joe Perches
2013-06-05 6:16 ` Takashi Iwai
2013-06-06 20:54 ` Alan Stern
2013-06-07 5:41 ` Takashi Iwai
2013-06-07 15:51 ` Alan Stern
2013-06-04 17:20 ` [PATCH 2/2 v.2] ALSA: get rid of CONFIG_SND_VERBOSE_PRINTK Alan Stern
2013-06-04 19:32 ` [PATCH] " Alan Stern
2013-06-04 19:45 ` Joe Perches
2013-06-04 20:54 ` Alan Stern
2013-06-04 21:19 ` Joe Perches [this message]
2013-06-06 20:42 ` Alan Stern
2013-06-06 20:59 ` Joe Perches
2013-06-07 14:40 ` Alan Stern
2013-06-07 16:10 ` Joe Perches
2013-06-05 6:04 ` Takashi Iwai
2013-06-05 6:15 ` Joe Perches
2013-06-05 6:32 ` Takashi Iwai
2013-06-05 6:52 ` Joe Perches
2013-06-05 6:54 ` Takashi Iwai
2013-06-05 7:07 ` Joe Perches
2013-06-05 7:22 ` Takashi Iwai
2013-06-05 7:34 ` Joe Perches
2013-06-05 7:47 ` CONFIG_SND_DEBUG (was: Re: [alsa-devel] [PATCH] ALSA: get rid of CONFIG_SND_VERBOSE_PRINTK) David Henningsson
2013-06-05 8:46 ` CONFIG_SND_DEBUG (was: " Takashi Iwai
2013-06-05 10:53 ` CONFIG_SND_DEBUG (was: Re: [alsa-devel] " Andy Whitcroft
2013-06-05 11:38 ` CONFIG_SND_DEBUG David Henningsson
2013-06-05 11:43 ` CONFIG_SND_DEBUG Takashi Iwai
2013-06-05 14:11 ` CONFIG_SND_DEBUG Alan Stern
2013-06-05 14:28 ` CONFIG_SND_DEBUG Takashi Iwai
2013-06-05 14:47 ` CONFIG_SND_DEBUG Alan Stern
2013-06-06 21:28 ` [PATCH] ALSA: get rid of CONFIG_SND_VERBOSE_PRINTK Alan Stern
2013-06-06 21:50 ` Joe Perches
2013-06-07 5:57 ` Takashi Iwai
2013-06-07 15:34 ` Alan Stern
2013-06-07 5:53 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1370380785.2385.69.camel@joe-AO722 \
--to=joe@perches.com \
--cc=alsa-devel@alsa-project.org \
--cc=stern@rowland.harvard.edu \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox