Re: [PATCH] ALSA: get rid of CONFIG_SND_VERBOSE_PRINTK

[Joe Perches <joe@perches.com>]

On Mon, 2013-06-03 at 16:40 -0400, Alan Stern wrote:
> On Mon, 3 Jun 2013, Joe Perches wrote:
> > On Mon, 2013-06-03 at 16:18 -0400, Alan Stern wrote:
> > > According to Takashi Iwai, CONFIG_SND_VERBOSE_PRINTK is "useless".  All 
> > > it does is add filenames and line numbers to certain log messages.
> > > This patch gets rid of it.
> > []
> > > Updating all the snd_printk() and snd_printd() calls will be a huge
> > > job.  Getting rid of the verbose logging is a lot easier, so that's
> > > where I'm starting.
> > 
> > cocci and emacs can make this pretty simple.
> 
> I wish they could, but I sincerely doubt that this conversion can be 
> mechanized.  At least, not if it is to be done correctly.

Completely mechanized/automated no, simpler though.

I still think the snd_printk uses should be converted to: 
	<snd_type>_<level>(<snd_type> *foo, fmt, ...)

[]

> > Please change the __snd_printk macros to remove __FILE__ and
> > __LINE__ (or 0, and 0) to remove some text from the objects.
> 
> Will do.

OK.

> I should have realized that originally...

No worries, it's a process.
Thanks for getting it started.