Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Mark Brown <broonie@kernel.org>
Cc: alsa-devel@alsa-project.org, Liam Girdwood <lgirdwood@gmail.com>
Subject: [PATCH 085/102] ASoC: isabelle: Use SOC_ENUM_SINGLE_CONST()
Date: Tue, 18 Feb 2014 12:51:31 +0100	[thread overview]
Message-ID: <1392724308-13375-5-git-send-email-tiwai@suse.de> (raw)
In-Reply-To: <1392724308-13375-1-git-send-email-tiwai@suse.de>

... for improving readability and maintainability.

Signed-off-by: Takashi Iwai <tiwai@suse.de>
---
 sound/soc/codecs/isabelle.c | 52 +++++++++++++++++++++------------------------
 1 file changed, 24 insertions(+), 28 deletions(-)

diff --git a/sound/soc/codecs/isabelle.c b/sound/soc/codecs/isabelle.c
index cb736ddc446d..3814719a9cc1 100644
--- a/sound/soc/codecs/isabelle.c
+++ b/sound/soc/codecs/isabelle.c
@@ -140,17 +140,17 @@ static const char *isabelle_rx1_texts[] = {"VRX1", "ARX1"};
 static const char *isabelle_rx2_texts[] = {"VRX2", "ARX2"};
 
 static const struct soc_enum isabelle_rx1_enum[] = {
-	SOC_ENUM_SINGLE(ISABELLE_VOICE_HPF_CFG_REG, 3,
-			ARRAY_SIZE(isabelle_rx1_texts), isabelle_rx1_texts),
-	SOC_ENUM_SINGLE(ISABELLE_AUDIO_HPF_CFG_REG, 5,
-			ARRAY_SIZE(isabelle_rx1_texts), isabelle_rx1_texts),
+	SOC_ENUM_SINGLE_CONST(ISABELLE_VOICE_HPF_CFG_REG, 3,
+			      isabelle_rx1_texts),
+	SOC_ENUM_SINGLE_CONST(ISABELLE_AUDIO_HPF_CFG_REG, 5,
+			      isabelle_rx1_texts),
 };
 
 static const struct soc_enum isabelle_rx2_enum[] = {
-	SOC_ENUM_SINGLE(ISABELLE_VOICE_HPF_CFG_REG, 2,
-			ARRAY_SIZE(isabelle_rx2_texts), isabelle_rx2_texts),
-	SOC_ENUM_SINGLE(ISABELLE_AUDIO_HPF_CFG_REG, 4,
-			ARRAY_SIZE(isabelle_rx2_texts), isabelle_rx2_texts),
+	SOC_ENUM_SINGLE_CONST(ISABELLE_VOICE_HPF_CFG_REG, 2,
+			      isabelle_rx2_texts),
+	SOC_ENUM_SINGLE_CONST(ISABELLE_AUDIO_HPF_CFG_REG, 4,
+			      isabelle_rx2_texts),
 };
 
 /* Headset DAC playback switches */
@@ -165,17 +165,17 @@ static const char *isabelle_atx_texts[] = {"AMIC1", "DMIC"};
 static const char *isabelle_vtx_texts[] = {"AMIC2", "DMIC"};
 
 static const struct soc_enum isabelle_atx_enum[] = {
-	SOC_ENUM_SINGLE(ISABELLE_AMIC_CFG_REG, 7,
-			ARRAY_SIZE(isabelle_atx_texts), isabelle_atx_texts),
-	SOC_ENUM_SINGLE(ISABELLE_DMIC_CFG_REG, 0,
-			ARRAY_SIZE(isabelle_atx_texts), isabelle_atx_texts),
+	SOC_ENUM_SINGLE_CONST(ISABELLE_AMIC_CFG_REG, 7,
+			      isabelle_atx_texts),
+	SOC_ENUM_SINGLE_CONST(ISABELLE_DMIC_CFG_REG, 0,
+			      isabelle_atx_texts),
 };
 
 static const struct soc_enum isabelle_vtx_enum[] = {
-	SOC_ENUM_SINGLE(ISABELLE_AMIC_CFG_REG, 6,
-			ARRAY_SIZE(isabelle_vtx_texts), isabelle_vtx_texts),
-	SOC_ENUM_SINGLE(ISABELLE_DMIC_CFG_REG, 0,
-			ARRAY_SIZE(isabelle_vtx_texts), isabelle_vtx_texts),
+	SOC_ENUM_SINGLE_CONST(ISABELLE_AMIC_CFG_REG, 6,
+			      isabelle_vtx_texts),
+	SOC_ENUM_SINGLE_CONST(ISABELLE_DMIC_CFG_REG, 0,
+			      isabelle_vtx_texts),
 };
 
 static const struct snd_kcontrol_new atx_mux_controls =
@@ -210,21 +210,17 @@ static const char *isabelle_st_audio_texts[] = {"ATX1", "ATX2"};
 static const char *isabelle_st_voice_texts[] = {"VTX1", "VTX2"};
 
 static const struct soc_enum isabelle_st_audio_enum[] = {
-	SOC_ENUM_SINGLE(ISABELLE_ATX_STPGA1_CFG_REG, 7,
-			ARRAY_SIZE(isabelle_st_audio_texts),
-			isabelle_st_audio_texts),
-	SOC_ENUM_SINGLE(ISABELLE_ATX_STPGA2_CFG_REG, 7,
-			ARRAY_SIZE(isabelle_st_audio_texts),
-			isabelle_st_audio_texts),
+	SOC_ENUM_SINGLE_CONST(ISABELLE_ATX_STPGA1_CFG_REG, 7,
+			      isabelle_st_audio_texts),
+	SOC_ENUM_SINGLE_CONST(ISABELLE_ATX_STPGA2_CFG_REG, 7,
+			      isabelle_st_audio_texts),
 };
 
 static const struct soc_enum isabelle_st_voice_enum[] = {
-	SOC_ENUM_SINGLE(ISABELLE_VTX_STPGA1_CFG_REG, 7,
-			ARRAY_SIZE(isabelle_st_voice_texts),
-			isabelle_st_voice_texts),
-	SOC_ENUM_SINGLE(ISABELLE_VTX2_STPGA2_CFG_REG, 7,
-			ARRAY_SIZE(isabelle_st_voice_texts),
-			isabelle_st_voice_texts),
+	SOC_ENUM_SINGLE_CONST(ISABELLE_VTX_STPGA1_CFG_REG, 7,
+			      isabelle_st_voice_texts),
+	SOC_ENUM_SINGLE_CONST(ISABELLE_VTX2_STPGA2_CFG_REG, 7,
+			      isabelle_st_voice_texts),
 };
 
 static const struct snd_kcontrol_new st_audio_control =
-- 
1.8.5.2

  parent reply	other threads:[~2014-02-18 11:51 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-18 11:51 [PATCH 000/102 - chunk#5] Add SOC_ENUM_SINGLE_CONST() & co Takashi Iwai
2014-02-18 11:51 ` [PATCH 082/102] ASoC: Add SOC_ENUM_SINGLE_CONST() and SOC_ENUM_DOUBLE_CONST() macros Takashi Iwai
2014-02-20  2:33   ` Mark Brown
2014-02-20  7:08     ` Takashi Iwai
2014-02-20  7:50       ` Takashi Iwai
2014-02-20  9:09       ` Mark Brown
2014-02-20 14:56         ` Takashi Iwai
2014-02-20 23:34           ` Mark Brown
2014-02-18 11:51 ` [PATCH 083/102] ASoC: ak4535: Use SOC_ENUM_SINGLE_CONST() Takashi Iwai
2014-02-18 11:51 ` [PATCH 084/102] ASoC: arizona: " Takashi Iwai
2014-02-18 11:51 ` Takashi Iwai [this message]
2014-02-18 11:51 ` [PATCH 086/102] ASoC: max9877: " Takashi Iwai
2014-02-18 11:51 ` [PATCH 087/102] ASoC: ssm2602: " Takashi Iwai
2014-02-18 11:51 ` [PATCH 088/102] ASoC: tas5086: " Takashi Iwai
2014-02-18 11:51 ` [PATCH 089/102] ASoC: tlv320aic3x: " Takashi Iwai
2014-02-18 11:51 ` [PATCH 090/102] ASoC: twl6040: " Takashi Iwai
2014-02-18 11:51 ` [PATCH 091/102] ASoC: uad134x: " Takashi Iwai
2014-02-18 11:51 ` [PATCH 092/102] ASoC: uad1380: " Takashi Iwai
2014-02-18 11:51 ` [PATCH 093/102] ASoC: wm8350: " Takashi Iwai
2014-02-18 11:51 ` [PATCH 094/102] ASoC: wm8510: " Takashi Iwai
2014-02-18 11:51 ` [PATCH 095/102] ASoC: wm8750: " Takashi Iwai
2014-02-18 11:51 ` [PATCH 096/102] ASoC: wm8753: " Takashi Iwai
2014-02-18 11:51 ` [PATCH 097/102] ASoC: wm8960: " Takashi Iwai
2014-02-18 11:51 ` [PATCH 098/102] ASoC: wm8971: " Takashi Iwai
2014-02-18 11:51 ` [PATCH 099/102] ASoC: wm8974: " Takashi Iwai
2014-02-18 11:51 ` [PATCH 100/102] ASoC: wm9712: " Takashi Iwai
2014-02-18 11:51 ` [PATCH 101/102] ASoC: wm9713: " Takashi Iwai
2014-02-18 11:51 ` [PATCH 102/102] ASoC: wm_adsp: " Takashi Iwai
2014-02-19  1:43 ` [PATCH 000/102 - chunk#5] Add SOC_ENUM_SINGLE_CONST() & co Mark Brown
2014-02-19  6:48   ` Takashi Iwai
2014-02-19  8:00     ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1392724308-13375-5-git-send-email-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=lgirdwood@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox