From: Mark Brown <broonie@kernel.org>
To: Takashi Iwai <tiwai@suse.de>
Cc: alsa-devel@alsa-project.org, Liam Girdwood <lgirdwood@gmail.com>
Subject: Re: [PATCH 082/102] ASoC: Add SOC_ENUM_SINGLE_CONST() and SOC_ENUM_DOUBLE_CONST() macros
Date: Thu, 20 Feb 2014 18:09:38 +0900 [thread overview]
Message-ID: <20140220090938.GA2669@sirena.org.uk> (raw)
In-Reply-To: <s5heh2yxnuk.wl%tiwai@suse.de>
[-- Attachment #1.1: Type: text/plain, Size: 896 bytes --]
On Thu, Feb 20, 2014 at 08:08:51AM +0100, Takashi Iwai wrote:
> Mark Brown wrote:
> > I'd also expect this to be more what the default naming does
> > since we want to try to steer people towards using the simplest and
> > least error prone mechanism for doing this.
> If changing the existing API is fine for you (not adding the new one),
> it's trivial to convert the patches to do so. Looking at the end
Yes, I think that's a better approach. It's fairly obvious that the
existing interface isn't awesome so it shouldn't be the default one.
> result, all SOC_ENUM_SINGLE() and SOC_ENUM_DOUBLE() usages are
> covered. For any specific usage in future, we may provide lowlevel
> macros, __SOC_ENUM_SINGLE() with the number of items, too.
Indeed, I was intending to go through and look at renaming the legacy
macros so they're implementaton details once I'd got through all the
patches.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2014-02-20 9:11 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-18 11:51 [PATCH 000/102 - chunk#5] Add SOC_ENUM_SINGLE_CONST() & co Takashi Iwai
2014-02-18 11:51 ` [PATCH 082/102] ASoC: Add SOC_ENUM_SINGLE_CONST() and SOC_ENUM_DOUBLE_CONST() macros Takashi Iwai
2014-02-20 2:33 ` Mark Brown
2014-02-20 7:08 ` Takashi Iwai
2014-02-20 7:50 ` Takashi Iwai
2014-02-20 9:09 ` Mark Brown [this message]
2014-02-20 14:56 ` Takashi Iwai
2014-02-20 23:34 ` Mark Brown
2014-02-18 11:51 ` [PATCH 083/102] ASoC: ak4535: Use SOC_ENUM_SINGLE_CONST() Takashi Iwai
2014-02-18 11:51 ` [PATCH 084/102] ASoC: arizona: " Takashi Iwai
2014-02-18 11:51 ` [PATCH 085/102] ASoC: isabelle: " Takashi Iwai
2014-02-18 11:51 ` [PATCH 086/102] ASoC: max9877: " Takashi Iwai
2014-02-18 11:51 ` [PATCH 087/102] ASoC: ssm2602: " Takashi Iwai
2014-02-18 11:51 ` [PATCH 088/102] ASoC: tas5086: " Takashi Iwai
2014-02-18 11:51 ` [PATCH 089/102] ASoC: tlv320aic3x: " Takashi Iwai
2014-02-18 11:51 ` [PATCH 090/102] ASoC: twl6040: " Takashi Iwai
2014-02-18 11:51 ` [PATCH 091/102] ASoC: uad134x: " Takashi Iwai
2014-02-18 11:51 ` [PATCH 092/102] ASoC: uad1380: " Takashi Iwai
2014-02-18 11:51 ` [PATCH 093/102] ASoC: wm8350: " Takashi Iwai
2014-02-18 11:51 ` [PATCH 094/102] ASoC: wm8510: " Takashi Iwai
2014-02-18 11:51 ` [PATCH 095/102] ASoC: wm8750: " Takashi Iwai
2014-02-18 11:51 ` [PATCH 096/102] ASoC: wm8753: " Takashi Iwai
2014-02-18 11:51 ` [PATCH 097/102] ASoC: wm8960: " Takashi Iwai
2014-02-18 11:51 ` [PATCH 098/102] ASoC: wm8971: " Takashi Iwai
2014-02-18 11:51 ` [PATCH 099/102] ASoC: wm8974: " Takashi Iwai
2014-02-18 11:51 ` [PATCH 100/102] ASoC: wm9712: " Takashi Iwai
2014-02-18 11:51 ` [PATCH 101/102] ASoC: wm9713: " Takashi Iwai
2014-02-18 11:51 ` [PATCH 102/102] ASoC: wm_adsp: " Takashi Iwai
2014-02-19 1:43 ` [PATCH 000/102 - chunk#5] Add SOC_ENUM_SINGLE_CONST() & co Mark Brown
2014-02-19 6:48 ` Takashi Iwai
2014-02-19 8:00 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140220090938.GA2669@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=lgirdwood@gmail.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox