Re: [PATCH 082/102] ASoC: Add SOC_ENUM_SINGLE_CONST() and SOC_ENUM_DOUBLE_CONST() macros

[Mark Brown <broonie@kernel.org>]

[-- Attachment #1.1: Type: text/plain, Size: 686 bytes --]

On Tue, Feb 18, 2014 at 12:51:28PM +0100, Takashi Iwai wrote:
> Add new helper macros for defining the enum elements with a constant
> array.  With these macros, redundant ARRAY_SIZE() can be removed in
> the code.

So, this doesn't seem like the best way to do things.  For one thing
it's not really that the arrays are const, it's the fact that they are a
fixed size that makes the difference with these macros.  An array where
we fill in a fixed number of strings at runtime would work just as well
for this.  I'd also expect this to be more what the default naming does
since we want to try to steer people towards using the simplest and
least error prone mechanism for doing this.

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]