* [PATCH] ASoC: tlv320aic23: Remove spurious bits per word setting
@ 2014-03-12 13:33 Mark Brown
2014-03-12 17:30 ` Max Filippov
0 siblings, 1 reply; 2+ messages in thread
From: Mark Brown @ 2014-03-12 13:33 UTC (permalink / raw)
To: Max Filippov, Liam Girdwood; +Cc: alsa-devel, linaro-kernel, Mark Brown
From: Mark Brown <broonie@linaro.org>
regmap should handle any byte ordering issues required, it is looking for
a byte stream from the bus, so don't set 16 bits per word. This is likely
to have tested out OK due to use of an unmerged SPI controller driver.
Signed-off-by: Mark Brown <broonie@linaro.org>
---
sound/soc/codecs/tlv320aic23-spi.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/sound/soc/codecs/tlv320aic23-spi.c b/sound/soc/codecs/tlv320aic23-spi.c
index 585aea436c6a..3b387e41d75d 100644
--- a/sound/soc/codecs/tlv320aic23-spi.c
+++ b/sound/soc/codecs/tlv320aic23-spi.c
@@ -25,7 +25,6 @@ static int aic23_spi_probe(struct spi_device *spi)
dev_dbg(&spi->dev, "probing tlv320aic23 spi device\n");
- spi->bits_per_word = 16;
spi->mode = SPI_MODE_0;
ret = spi_setup(spi);
if (ret < 0)
--
1.9.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ASoC: tlv320aic23: Remove spurious bits per word setting
2014-03-12 13:33 [PATCH] ASoC: tlv320aic23: Remove spurious bits per word setting Mark Brown
@ 2014-03-12 17:30 ` Max Filippov
0 siblings, 0 replies; 2+ messages in thread
From: Max Filippov @ 2014-03-12 17:30 UTC (permalink / raw)
To: Mark Brown; +Cc: alsa-devel, linaro-kernel, Liam Girdwood, Mark Brown
On Wed, Mar 12, 2014 at 5:33 PM, Mark Brown <broonie@kernel.org> wrote:
> From: Mark Brown <broonie@linaro.org>
>
> regmap should handle any byte ordering issues required, it is looking for
> a byte stream from the bus, so don't set 16 bits per word. This is likely
> to have tested out OK due to use of an unmerged SPI controller driver.
>
> Signed-off-by: Mark Brown <broonie@linaro.org>
> ---
> sound/soc/codecs/tlv320aic23-spi.c | 1 -
> 1 file changed, 1 deletion(-)
Tested-by: Max Filippov <jcmvbkbc@gmail.com>
> diff --git a/sound/soc/codecs/tlv320aic23-spi.c b/sound/soc/codecs/tlv320aic23-spi.c
> index 585aea436c6a..3b387e41d75d 100644
> --- a/sound/soc/codecs/tlv320aic23-spi.c
> +++ b/sound/soc/codecs/tlv320aic23-spi.c
> @@ -25,7 +25,6 @@ static int aic23_spi_probe(struct spi_device *spi)
>
> dev_dbg(&spi->dev, "probing tlv320aic23 spi device\n");
>
> - spi->bits_per_word = 16;
> spi->mode = SPI_MODE_0;
> ret = spi_setup(spi);
> if (ret < 0)
> --
> 1.9.0
>
--
Thanks.
-- Max
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-03-12 17:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-03-12 13:33 [PATCH] ASoC: tlv320aic23: Remove spurious bits per word setting Mark Brown
2014-03-12 17:30 ` Max Filippov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox