Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] conf/ucm: broadwell-rt286: change to set capture volume and capture device
@ 2015-05-08  7:18 Jie Yang
  2015-05-11 14:22 ` Mark Brown
  2015-05-18  8:44 ` Takashi Iwai
  0 siblings, 2 replies; 3+ messages in thread
From: Jie Yang @ 2015-05-08  7:18 UTC (permalink / raw)
  To: tiwai; +Cc: alsa-devel, broonie, liam.r.girdwood

Set 'Mic Capture Volume' in capture device EnableSequence, to fix
capture no volume by default issue.

Also add JackHWMute Value item to mute onboard dmic while headset
mic is plugged in.

Signed-off-by: Jie Yang <yang.jie@intel.com>
---
 src/conf/ucm/broadwell-rt286/HiFi | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/src/conf/ucm/broadwell-rt286/HiFi b/src/conf/ucm/broadwell-rt286/HiFi
index 58983ea..c09a01c 100644
--- a/src/conf/ucm/broadwell-rt286/HiFi
+++ b/src/conf/ucm/broadwell-rt286/HiFi
@@ -86,6 +86,7 @@ SectionDevice."Handset" {
 	EnableSequence [
 		cdev "hw:broadwellrt286"
 
+		cset "name='Mic Capture Volume' 28"
 		cset "name='ADC 0 Mux' 0"
 		cset "name='ADC0 Capture Switch' on"
 		cset "name='ADC0 Capture Volume' 127"
@@ -99,6 +100,9 @@ SectionDevice."Handset" {
 
 	Value {
 		CaptureChannels "2"
+		JackDev "rt286-jack"
+		JackControl "Mic Jack"
+		JackHWMute "Mainmic"
 	}
 }
 
@@ -112,6 +116,7 @@ SectionDevice."Mainmic" {
 	EnableSequence [
 		cdev "hw:broadwellrt286"
 
+		cset "name='Mic Capture Volume' 30"
 		cset "name='ADC 0 Mux' 2"
 		cset "name='ADC0 Capture Switch' on"
 		cset "name='ADC0 Capture Volume' 127"
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] conf/ucm: broadwell-rt286: change to set capture volume and capture device
  2015-05-08  7:18 [PATCH] conf/ucm: broadwell-rt286: change to set capture volume and capture device Jie Yang
@ 2015-05-11 14:22 ` Mark Brown
  2015-05-18  8:44 ` Takashi Iwai
  1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2015-05-11 14:22 UTC (permalink / raw)
  To: Jie Yang; +Cc: tiwai, alsa-devel, liam.r.girdwood


[-- Attachment #1.1: Type: text/plain, Size: 444 bytes --]

On Fri, May 08, 2015 at 03:18:47PM +0800, Jie Yang wrote:
> Set 'Mic Capture Volume' in capture device EnableSequence, to fix
> capture no volume by default issue.
> 
> Also add JackHWMute Value item to mute onboard dmic while headset
> mic is plugged in.

Tested-by: Mark Brown <broonie@kernel.org>

It'd be good to have a release with this in, it's the main missing bit
to getting my current laptop's audio working out of the box.

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] conf/ucm: broadwell-rt286: change to set capture volume and capture device
  2015-05-08  7:18 [PATCH] conf/ucm: broadwell-rt286: change to set capture volume and capture device Jie Yang
  2015-05-11 14:22 ` Mark Brown
@ 2015-05-18  8:44 ` Takashi Iwai
  1 sibling, 0 replies; 3+ messages in thread
From: Takashi Iwai @ 2015-05-18  8:44 UTC (permalink / raw)
  To: Jie Yang; +Cc: alsa-devel, broonie, liam.r.girdwood

At Fri,  8 May 2015 15:18:47 +0800,
Jie Yang wrote:
> 
> Set 'Mic Capture Volume' in capture device EnableSequence, to fix
> capture no volume by default issue.
> 
> Also add JackHWMute Value item to mute onboard dmic while headset
> mic is plugged in.
> 
> Signed-off-by: Jie Yang <yang.jie@intel.com>

Applied, thanks.


Takashi

> ---
>  src/conf/ucm/broadwell-rt286/HiFi | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/src/conf/ucm/broadwell-rt286/HiFi b/src/conf/ucm/broadwell-rt286/HiFi
> index 58983ea..c09a01c 100644
> --- a/src/conf/ucm/broadwell-rt286/HiFi
> +++ b/src/conf/ucm/broadwell-rt286/HiFi
> @@ -86,6 +86,7 @@ SectionDevice."Handset" {
>  	EnableSequence [
>  		cdev "hw:broadwellrt286"
>  
> +		cset "name='Mic Capture Volume' 28"
>  		cset "name='ADC 0 Mux' 0"
>  		cset "name='ADC0 Capture Switch' on"
>  		cset "name='ADC0 Capture Volume' 127"
> @@ -99,6 +100,9 @@ SectionDevice."Handset" {
>  
>  	Value {
>  		CaptureChannels "2"
> +		JackDev "rt286-jack"
> +		JackControl "Mic Jack"
> +		JackHWMute "Mainmic"
>  	}
>  }
>  
> @@ -112,6 +116,7 @@ SectionDevice."Mainmic" {
>  	EnableSequence [
>  		cdev "hw:broadwellrt286"
>  
> +		cset "name='Mic Capture Volume' 30"
>  		cset "name='ADC 0 Mux' 2"
>  		cset "name='ADC0 Capture Switch' on"
>  		cset "name='ADC0 Capture Volume' 127"
> -- 
> 1.9.1
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2015-05-18  8:44 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-05-08  7:18 [PATCH] conf/ucm: broadwell-rt286: change to set capture volume and capture device Jie Yang
2015-05-11 14:22 ` Mark Brown
2015-05-18  8:44 ` Takashi Iwai

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox