* [PATCH] ASoc: tpa6130a2: Remove unnecessary variable
@ 2010-01-04 12:30 Ilkka Koskinen
2010-01-04 12:30 ` Peter Ujfalusi
2010-01-04 18:32 ` Mark Brown
0 siblings, 2 replies; 3+ messages in thread
From: Ilkka Koskinen @ 2010-01-04 12:30 UTC (permalink / raw)
To: alsa-devel; +Cc: broonie, peter.ujfalusi
Signed-off-by: Ilkka Koskinen <ilkka.koskinen@nokia.com>
---
sound/soc/codecs/tpa6130a2.c | 4 ----
1 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/sound/soc/codecs/tpa6130a2.c b/sound/soc/codecs/tpa6130a2.c
index 0eb33d4..8e98ccf 100644
--- a/sound/soc/codecs/tpa6130a2.c
+++ b/sound/soc/codecs/tpa6130a2.c
@@ -267,12 +267,8 @@ static const struct snd_kcontrol_new tpa6130a2_controls[] = {
*/
static void tpa6130a2_channel_enable(u8 channel, int enable)
{
- struct tpa6130a2_data *data;
u8 val;
- BUG_ON(tpa6130a2_client == NULL);
- data = i2c_get_clientdata(tpa6130a2_client);
-
if (enable) {
/* Enable channel */
/* Enable amplifier */
--
1.6.0.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] ASoc: tpa6130a2: Remove unnecessary variable
2010-01-04 12:30 [PATCH] ASoc: tpa6130a2: Remove unnecessary variable Ilkka Koskinen
@ 2010-01-04 12:30 ` Peter Ujfalusi
2010-01-04 18:32 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Peter Ujfalusi @ 2010-01-04 12:30 UTC (permalink / raw)
To: Koskinen Ilkka (Nokia-D/Tampere)
Cc: alsa-devel@alsa-project.org, broonie@opensource.wolfsonmicro.com
On Monday 04 January 2010 14:30:03 Koskinen Ilkka (Nokia-D/Tampere) wrote:
> Signed-off-by: Ilkka Koskinen <ilkka.koskinen@nokia.com>
> ---
> sound/soc/codecs/tpa6130a2.c | 4 ----
> 1 files changed, 0 insertions(+), 4 deletions(-)
>
> diff --git a/sound/soc/codecs/tpa6130a2.c b/sound/soc/codecs/tpa6130a2.c
> index 0eb33d4..8e98ccf 100644
> --- a/sound/soc/codecs/tpa6130a2.c
> +++ b/sound/soc/codecs/tpa6130a2.c
> @@ -267,12 +267,8 @@ static const struct snd_kcontrol_new
> tpa6130a2_controls[] = { */
> static void tpa6130a2_channel_enable(u8 channel, int enable)
> {
> - struct tpa6130a2_data *data;
> u8 val;
>
> - BUG_ON(tpa6130a2_client == NULL);
> - data = i2c_get_clientdata(tpa6130a2_client);
> -
> if (enable) {
> /* Enable channel */
> /* Enable amplifier */
Yes, I think this is a leftover from some earlier code that I had.
Good catch!
Acked-by: Peter Ujfalusi <peter.ujfalusi@nokia.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] ASoc: tpa6130a2: Remove unnecessary variable
2010-01-04 12:30 [PATCH] ASoc: tpa6130a2: Remove unnecessary variable Ilkka Koskinen
2010-01-04 12:30 ` Peter Ujfalusi
@ 2010-01-04 18:32 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2010-01-04 18:32 UTC (permalink / raw)
To: Ilkka Koskinen; +Cc: alsa-devel, peter.ujfalusi
On Mon, Jan 04, 2010 at 02:30:03PM +0200, Ilkka Koskinen wrote:
> Signed-off-by: Ilkka Koskinen <ilkka.koskinen@nokia.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-01-04 18:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-01-04 12:30 [PATCH] ASoc: tpa6130a2: Remove unnecessary variable Ilkka Koskinen
2010-01-04 12:30 ` Peter Ujfalusi
2010-01-04 18:32 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox