* [PATCH] ASoC: fsi codecs: modify menu attribute on Kconfig
@ 2010-09-10 1:34 Kuninori Morimoto
2010-09-10 11:20 ` Liam Girdwood
2010-09-10 11:39 ` Mark Brown
0 siblings, 2 replies; 3+ messages in thread
From: Kuninori Morimoto @ 2010-09-10 1:34 UTC (permalink / raw)
To: Mark Brown; +Cc: Linux-ALSA, Guennadi, Liam Girdwood
Current SND_FSI_xxx menu attributes were bool,
but it should be tristate.
This patch solve below report from Guennadi
"bool" means, if someone is linking the whole ASoC into the kernel, they
will not be able to build this as a module. Not a big deal, but you're
stealing some freedom from the user.
Reported-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
sound/soc/sh/Kconfig | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/sound/soc/sh/Kconfig b/sound/soc/sh/Kconfig
index 6b224d2..7f0a496 100644
--- a/sound/soc/sh/Kconfig
+++ b/sound/soc/sh/Kconfig
@@ -47,7 +47,7 @@ config SND_SH7760_AC97
AC97 unit of the SH7760.
config SND_FSI_AK4642
- bool "FSI-AK4642 sound support"
+ tristate "FSI-AK4642 sound support"
depends on SND_SOC_SH4_FSI && I2C_SH_MOBILE
select SND_SOC_AK4642
help
@@ -55,7 +55,7 @@ config SND_FSI_AK4642
FSI - AK4642 unit
config SND_FSI_DA7210
- bool "FSI-DA7210 sound support"
+ tristate "FSI-DA7210 sound support"
depends on SND_SOC_SH4_FSI && I2C_SH_MOBILE
select SND_SOC_DA7210
help
@@ -63,7 +63,7 @@ config SND_FSI_DA7210
FSI - DA7210 unit
config SND_FSI_HDMI
- bool "FSI-HDMI sound support"
+ tristate "FSI-HDMI sound support"
depends on SND_SOC_SH4_FSI && FB_SH_MOBILE_HDMI
help
This option enables generic sound support for the
--
1.7.0.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ASoC: fsi codecs: modify menu attribute on Kconfig
2010-09-10 1:34 [PATCH] ASoC: fsi codecs: modify menu attribute on Kconfig Kuninori Morimoto
@ 2010-09-10 11:20 ` Liam Girdwood
2010-09-10 11:39 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Liam Girdwood @ 2010-09-10 11:20 UTC (permalink / raw)
To: Kuninori Morimoto; +Cc: Linux-ALSA, Mark Brown, Guennadi
On Fri, 2010-09-10 at 10:34 +0900, Kuninori Morimoto wrote:
> Current SND_FSI_xxx menu attributes were bool,
> but it should be tristate.
> This patch solve below report from Guennadi
>
> "bool" means, if someone is linking the whole ASoC into the kernel, they
> will not be able to build this as a module. Not a big deal, but you're
> stealing some freedom from the user.
>
> Reported-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Acked-by: Liam Girdwood <lrg@slimlogic.co.uk>
--
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ASoC: fsi codecs: modify menu attribute on Kconfig
2010-09-10 1:34 [PATCH] ASoC: fsi codecs: modify menu attribute on Kconfig Kuninori Morimoto
2010-09-10 11:20 ` Liam Girdwood
@ 2010-09-10 11:39 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2010-09-10 11:39 UTC (permalink / raw)
To: Kuninori Morimoto; +Cc: Linux-ALSA, Guennadi, Liam Girdwood
On Fri, Sep 10, 2010 at 10:34:32AM +0900, Kuninori Morimoto wrote:
> Current SND_FSI_xxx menu attributes were bool,
> but it should be tristate.
> This patch solve below report from Guennadi
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-09-10 11:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-09-10 1:34 [PATCH] ASoC: fsi codecs: modify menu attribute on Kconfig Kuninori Morimoto
2010-09-10 11:20 ` Liam Girdwood
2010-09-10 11:39 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox