* [PATCH] ALSA: hda - Fix ALC660-VD/ALC861-VD capture/playback mixers
@ 2010-11-25 2:08 Herton Ronaldo Krzesinski
2010-11-25 9:21 ` Takashi Iwai
0 siblings, 1 reply; 2+ messages in thread
From: Herton Ronaldo Krzesinski @ 2010-11-25 2:08 UTC (permalink / raw)
To: alsa-devel; +Cc: Takashi Iwai
The mixer nids passed to alc_auto_create_input_ctls are wrong: 0x15 is
a pin, and 0x09 is the ADC on both ALC660-VD/ALC861-VD. Thus with
current code, input playback volume/switches and input source mixer
controls are not created, and recording doesn't work. Select correct
mixers, 0x0b (input playback mixer) and 0x22 (capture source mixer).
Reference: https://qa.mandriva.com/show_bug.cgi?id=61159
Signed-off-by: Herton Ronaldo Krzesinski <herton@mandriva.com.br>
---
sound/pci/hda/patch_realtek.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index b4b3afe..5aafae9 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -16952,7 +16952,7 @@ static struct alc_config_preset alc861vd_presets[] = {
static int alc861vd_auto_create_input_ctls(struct hda_codec *codec,
const struct auto_pin_cfg *cfg)
{
- return alc_auto_create_input_ctls(codec, cfg, 0x15, 0x09, 0);
+ return alc_auto_create_input_ctls(codec, cfg, 0x0b, 0x22, 0);
}
--
1.7.3.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ALSA: hda - Fix ALC660-VD/ALC861-VD capture/playback mixers
2010-11-25 2:08 [PATCH] ALSA: hda - Fix ALC660-VD/ALC861-VD capture/playback mixers Herton Ronaldo Krzesinski
@ 2010-11-25 9:21 ` Takashi Iwai
0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2010-11-25 9:21 UTC (permalink / raw)
To: Herton Ronaldo Krzesinski; +Cc: alsa-devel
At Thu, 25 Nov 2010 00:08:01 -0200,
Herton Ronaldo Krzesinski wrote:
>
> The mixer nids passed to alc_auto_create_input_ctls are wrong: 0x15 is
> a pin, and 0x09 is the ADC on both ALC660-VD/ALC861-VD. Thus with
> current code, input playback volume/switches and input source mixer
> controls are not created, and recording doesn't work. Select correct
> mixers, 0x0b (input playback mixer) and 0x22 (capture source mixer).
>
> Reference: https://qa.mandriva.com/show_bug.cgi?id=61159
>
> Signed-off-by: Herton Ronaldo Krzesinski <herton@mandriva.com.br>
Applied now. Thanks!
Takashi
> ---
> sound/pci/hda/patch_realtek.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index b4b3afe..5aafae9 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -16952,7 +16952,7 @@ static struct alc_config_preset alc861vd_presets[] = {
> static int alc861vd_auto_create_input_ctls(struct hda_codec *codec,
> const struct auto_pin_cfg *cfg)
> {
> - return alc_auto_create_input_ctls(codec, cfg, 0x15, 0x09, 0);
> + return alc_auto_create_input_ctls(codec, cfg, 0x0b, 0x22, 0);
> }
>
>
> --
> 1.7.3.2
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-11-25 9:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-11-25 2:08 [PATCH] ALSA: hda - Fix ALC660-VD/ALC861-VD capture/playback mixers Herton Ronaldo Krzesinski
2010-11-25 9:21 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox