From: Peter Ujfalusi <peter.ujfalusi@nokia.com>
To: alsa-devel@alsa-project.org
Cc: ext Mark Brown <broonie@opensource.wolfsonmicro.com>,
Liam Girdwood <lrg@slimlogic.co.uk>
Subject: Re: [RFC 2/2] ASoC: tlv320dac33: Request for reordered update power sequence
Date: Thu, 2 Dec 2010 14:52:04 +0200 [thread overview]
Message-ID: <201012021452.04720.peter.ujfalusi@nokia.com> (raw)
In-Reply-To: <20101202122423.GB859@rakim.wolfsonmicro.main>
On Thursday 02 December 2010 14:24:23 ext Mark Brown wrote:
> On Thu, Dec 02, 2010 at 02:03:10PM +0200, Peter Ujfalusi wrote:
> > + codec->dapm.dapm_reorder_pupdate = 1;
I'm really bad at naming for sure.
> Sorry, meant to say on the previous patch: it's also not ideal that this
> affects all widgets on the CODEC, it means that this is an all or
> nothing change which isn't ideal.
That was my intention to have the ability set this reordered mode for the codec.
Back to the naming.. What about reorder_dapm_update_power, and move the flag to
the snd_soc_dapm_widget struct?
I could think two ways of moving this per widget config:
Either add new widgets:
SND_SOC_DAPM_REORDERED_SWITCH, and SND_SOC_DAPM_REORDERED_SWITCH_E, which will
have the same list of parameters, but sets the reorder_dapm_update_power flag
for the widget.
But the widget names looks terible.
Or have a helper function, which can set this flag for the given widget,
something like:
snd_soc_dapm_set_update_power_reordering(struct snd_soc_codec *codec, const char
*name);
It will find the widget, and sets the flag for that widget only.
The function name again looks bad.
--
Péter
next prev parent reply other threads:[~2010-12-02 12:52 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-02 12:03 [RFC 0/2] ASoC: core: Option to reorder widget power sequence Peter Ujfalusi
2010-12-02 12:03 ` [RFC 1/2] ASoC: core: Reordered DAPM update power on widgets Peter Ujfalusi
2010-12-02 12:21 ` Mark Brown
2010-12-02 12:54 ` Peter Ujfalusi
2010-12-02 12:03 ` [RFC 2/2] ASoC: tlv320dac33: Request for reordered update power sequence Peter Ujfalusi
2010-12-02 12:24 ` Mark Brown
2010-12-02 12:52 ` Peter Ujfalusi [this message]
2010-12-02 13:15 ` Mark Brown
2010-12-03 9:36 ` Peter Ujfalusi
2010-12-02 13:05 ` [RFC 0/2] ASoC: core: Option to reorder widget " Mark Brown
2010-12-03 7:33 ` Peter Ujfalusi
2010-12-03 14:48 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201012021452.04720.peter.ujfalusi@nokia.com \
--to=peter.ujfalusi@nokia.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=lrg@slimlogic.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox