Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Ujfalusi <peter.ujfalusi@nokia.com>
To: ext Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
	Liam Girdwood <lrg@slimlogic.co.uk>
Subject: Re: [RFC 1/2] ASoC: core: Reordered DAPM update power on widgets
Date: Thu, 2 Dec 2010 14:54:30 +0200	[thread overview]
Message-ID: <201012021454.30943.peter.ujfalusi@nokia.com> (raw)
In-Reply-To: <20101202122128.GA859@rakim.wolfsonmicro.main>

On Thursday 02 December 2010 14:21:28 ext Mark Brown wrote:
> On Thu, Dec 02, 2010 at 02:03:09PM +0200, Peter Ujfalusi wrote:
> > +	unsigned int dapm_reorder_pupdate:1; /* Reordered pupdate in widgets */
> 
> Please use a more meaningful name than pupdate, I can't parse what that
> stands for easily (I'm guessing power update?) and even with that it's
> not clear what the option actually does.

I'll try to figure out better name.

> 
> > +	unsigned int change, dapm_pupdate_first = 1;
> 
> Please split the new variable onto a separate line - mixed initialised
> and uninitialised variables are confusing to read.

True.
 
> > -	if (snd_soc_test_bits(widget->codec, reg, val_mask, val)) {
> > -		if (val)
> > -			/* new connection */
> > -			connect = invert ? 0:1;
> > -		else
> > -			/* old connection must be powered down */
> > -			connect = invert ? 1:0;
> > +	change = snd_soc_test_bits(widget->codec, reg, val_mask, val);
> > +	if (val)
> > +		/* new connection */
> > +		connect = invert ? 0 : 1;
> > +	else
> > +		/* old connection must be powered down */
> 
> This is really confusing - if there's no change why are we not just
> exiting the function immediately?  It makes the rest of the code much
> harder to follow as the conditionals all get more complex.

Yes, in that case we do not even need the change variable, since if there is no 
change I just: goto out;
Makes it cleaner.

Thanks,
Péter

  reply	other threads:[~2010-12-02 12:54 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-02 12:03 [RFC 0/2] ASoC: core: Option to reorder widget power sequence Peter Ujfalusi
2010-12-02 12:03 ` [RFC 1/2] ASoC: core: Reordered DAPM update power on widgets Peter Ujfalusi
2010-12-02 12:21   ` Mark Brown
2010-12-02 12:54     ` Peter Ujfalusi [this message]
2010-12-02 12:03 ` [RFC 2/2] ASoC: tlv320dac33: Request for reordered update power sequence Peter Ujfalusi
2010-12-02 12:24   ` Mark Brown
2010-12-02 12:52     ` Peter Ujfalusi
2010-12-02 13:15       ` Mark Brown
2010-12-03  9:36         ` Peter Ujfalusi
2010-12-02 13:05 ` [RFC 0/2] ASoC: core: Option to reorder widget " Mark Brown
2010-12-03  7:33   ` Peter Ujfalusi
2010-12-03 14:48     ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201012021454.30943.peter.ujfalusi@nokia.com \
    --to=peter.ujfalusi@nokia.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=lrg@slimlogic.co.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox